Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependency to shelljs is printing unwanted warnings #684

Closed
ArchangelX360 opened this issue Jun 25, 2021 · 1 comment
Closed

Outdated dependency to shelljs is printing unwanted warnings #684

ArchangelX360 opened this issue Jun 25, 2021 · 1 comment

Comments

@ArchangelX360
Copy link
Contributor

Describe the bug
Dependency shelljs in version 0.8.3 is printing warnings with specific versions of NodeJS, see shelljs/shelljs#992.

As @kubernetes/client-node depends on it, we are seeing those warnings at runtime:

(node:29099) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
    at emitCircularRequireWarning (node:internal/modules/cjs/loader:703:11)
    at Object.get (node:internal/modules/cjs/loader:717:5)
    at Object._register [as register] ([REDACTED]/node_modules/@kubernetes/client-node/node_modules/shelljs/src/common.js:453:12)
    at Object.<anonymous> ([REDACTED]/node_modules/@kubernetes/client-node/node_modules/shelljs/src/cat.js:4:8)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
// ...

Upgrading to shelljs 0.8.4 should be sufficient to resolve the issue.

** Client Version **
0.12.3

** Server Version **
N/A

Expected behavior
No warnings

Environment (please complete the following information):

  • OS: MacOS BigSur
  • NodeJS Version 16.3.0

Additional context

@brendandburns
Copy link
Contributor

Closing this since #685 merged and 0.15.0 has been pushed with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants