capacity: add benchmark for CSIStorageCapacity update #706
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
It may be possible to optimize updating capacity by using patching. Before trying that we need a benchmark. This benchmark acts as a client with basically unlimited local rate limits. When run long enough, the results are stable: $ go test -run=xxx -bench=. -count=5 -benchtime=1m . | tee /tmp/log ... $ $GOPATH/bin/benchstat /tmp/log name time/op CapacityUpdate-36 3.93ms ± 1%
|
@pohly: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
There doesn't seem to be enough interest in having these benchmarks included in the repo. /close |
|
@pohly: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
It may be possible to optimize updating capacity by using patching. Before
trying that we need a benchmark.
Which issue(s) this PR fixes:
Fixes #467
Special notes for your reviewer:
This benchmark acts as a client with basically unlimited local rate
limits. When run long enough, the results are stable:
Does this PR introduce a user-facing change?: