Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationale behind xfrChannelSize set to const value of 10 and 150 #586

Open
ipochi opened this issue Mar 15, 2024 · 4 comments
Open

Rationale behind xfrChannelSize set to const value of 10 and 150 #586

ipochi opened this issue Mar 15, 2024 · 4 comments
Assignees

Comments

@ipochi
Copy link
Contributor

ipochi commented Mar 15, 2024

I'd like to understand the reasons for choosing const xfrChannelSize = 150 in pkg/agent/client.go and const xfrChannelSize = 10 in pkg/server/server.go

I see a lot of logs in the konnectivity-server with

I0315 11:16:53.457102       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.457420       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.457882       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458218       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458260       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458283       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458292       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458301       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458317       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458328       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458340       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458361       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458382       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458402       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458419       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458432       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458452       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.458959       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.459348       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.459738       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.460080       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00
I0315 11:16:53.460875       1 server.go:853] "Receive channel from agent is full" agentID=0x15e8e00

What are my options to improve ? Make the xfrChannelSize configurable via the cli flag ? I'd like to know some historical context as to what thoughts were put into this value?

Also correct me if I'm wrong if the above xfrChannelSize has everything/nothing to do with the above log.

//cc @jkh52 @cheftako

@jkh52
Copy link
Contributor

jkh52 commented Mar 15, 2024

@cheftako do you think this history could be a discussion for the next OSS biweekly? I remember some of the history here but you have the most context.

/assign @cheftako

@jkh52
Copy link
Contributor

jkh52 commented Mar 29, 2024

The meeting on 2024-03-20 discussed this topic. (@cheftako can you find the recording link?)

@ipochi do you want to pursue adding flags to support changing these values?

/assign @ipochi

@cnvergence
Copy link

I have found the same issue, any progress on this one?
Can I help with this topic?

@cnvergence
Copy link

cnvergence commented May 6, 2024

I would like to work on it, being able to open PR soon, would it work for your @ipochi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants