Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert our repo to be a rust workspace #218

Closed
astoycos opened this issue Apr 4, 2024 · 4 comments · Fixed by #227
Closed

Convert our repo to be a rust workspace #218

astoycos opened this issue Apr 4, 2024 · 4 comments · Fixed by #227
Assignees
@EandrewJones
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v0.4.0 - Rewrite ...

Comments

@astoycos
Copy link
Member

astoycos commented Apr 4, 2024 •
edited

A rust workspace will allow all our rust modules/crates to have dependency management and versioning from a central point while still coe-exising with our go processes.

Again this is what we do in bpfman so that can be a good reference
@astoycos astoycos added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 4, 2024
@shaneutt
Copy link
Member

shaneutt commented Apr 4, 2024

Makes perfect sense since we're moving to all Rust soon. 👍

@astoycos
Copy link
Member Author

astoycos commented Apr 5, 2024

@EandrewJones no rush at all but if you want to keep helping this is a logical good next issue :)

@EandrewJones
Copy link
Contributor

@EandrewJones no rush at all but if you want to keep helping this is a logical good next issue :)

I can pick this up. I started work on #50 already, but I can bracket that for now.

@astoycos
Copy link
Member Author

astoycos commented Apr 5, 2024 •
edited

/assign @EandrewJones

Yeah I think #50 isn't as important, we can discuss further priorities during our meeting

@EandrewJones EandrewJones mentioned this issue Apr 19, 2024
Merged
k8s-ci-robot added a commit that referenced this issue May 31, 2024
@k8s-ci-robot
chore(cargo workspace): unifies crates as workspace (#227)
2df33c4 
## Changes

Combines all rust crates under a single workspace to simplify management
of rust packaging.

> *_Note:_* All crates are converted to the workspace with the exception
of ebpf which needs independent tooling and packages to properly build.

Closes #218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EandrewJones EandrewJones

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Blixt Project Board
Status: Done
Milestone
v0.4.0 - Rewrite of the controlplane ...
Development

Successfully merging a pull request may close this issue.

chore(cargo workspace): unifies crates as workspace EandrewJones/blixt
3 participants
@shaneutt @astoycos @EandrewJones