Keep reading SBOM until encoding is found #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
puerco
force-pushed
the
full-parse
branch
2 times, most recently
from
0af9d89
to
4e7be20
Compare
This commit modifies the encoding detection function to read the as much of the SBOM as required to deetect the encoding. Some tools (notably Microsoft's sbom-tool) put the document creation data at the end of the document and we could not detect the encoding by reading a few bytes from the top. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit removes some debugging messages which were accidentaly checked in into the outlining code. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This PR modifies the encoding detection function to read
the as much of the SBOM as required to detect the encoding.
Some tools (notably Microsoft's
sbom-tool) put the documentcreation data at the end of the document and we could not detect it by reading just a few bytes from the top.
I pushed another commit removing some debugging output I accidentally checked in.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?