Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSInfo: Add support for download location #270

Merged
merged 1 commit into from
Apr 15, 2023
Merged

OSInfo: Add support for download location #270

merged 1 commit into from
Apr 15, 2023

Conversation

puerco
Copy link
Member

@puerco puerco commented Apr 15, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new DownloadLocation()`` function to the osinfo.PackageDBEntry` type which can generate a download location for system packages which can be used in the SBOM. It will now be used there when it is not an empty string.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

OS Packages now can include an auto-generated download location. Initially supports Debian and Wolfi.

@puerco
OSInfo: Add support for download location
1f17c83 
This commit adds a new DownloadLocation function to the osdebentry object
which can generate a download location for packages to use in the SBOM. It
will now be used there when it is not an empty string.

Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@k8s-ci-robot
Copy link
Contributor

@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new DownloadLocation()`` function to the osinfo.PackageDBEntry` type which can generate a download location for system packages which can be used in the SBOM. It will now be used there when it is not an empty string.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

OS Packages now can include an auto-generated download location. Initially supports Debian and Wolfi.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34634f6 into kubernetes-sigs:main Apr 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puerco @k8s-ci-robot @cpanato