Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable scope creep in SPDX file processor #312

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix variable scope creep in SPDX file processor #312

merged 1 commit into from
Jul 6, 2023

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a race condition caused by a variable scope creep in the file processor when scanning directories.

Which issue(s) this PR fixes:

Fixes #308

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

Fixed a race condition where concurrent files canning processes could clash and cause a segfault (thanks to @howardjohn for reporting)

@k8s-ci-robot
Copy link
Contributor

@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a race condition caused by a variable scope creep in the file processor when scanning directories.

Which issue(s) this PR fixes:

Fixes #308

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

Fixed a race condition where concurrent files canning processes could clash and cause a segfault (thanks to @howardjohn for reporting)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
@puerco
Fix variable scope creep in SPDX file processor
48dbbaa 
This commits fixes a race condition caused by a variable scope creep
in the file processor.

Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
Verolop
Verolop reviewed Jul 6, 2023
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit f0ff48f into kubernetes-sigs:main Jul 6, 2023
7 checks passed
@mtardy mtardy mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop left review comments

Assignees

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PackageFromDirectory segfault
3 participants
@puerco @k8s-ci-robot @Verolop