OSInfo: Distroless Scanner #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit refactors some of the tarcode in the layer scanner to reuse it some of the functions. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit moves some messages to the debugger level to reduce the verbosity of bom when running. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit fixes a bug where the debian scanner would drop the last OS pacakge read from the database Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit fixes a bug in the version encoding when generating purls from image references. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
|
Example generating an SBOM of the kube-apiserver image:
|
|
After this one merges we should cut a new release |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This PR adds a new OS Info image scanner to support the scanning of images based on distroless.
At this time it will read OS packages from the split dpkg database used by distroless. Support for files could be added later, the test fixtures include file data when we decide to implement it.
The layer scanner now has a function to extract directories from tarballs, I refactored the tar logic to reuse some of the code among the different tar functions.
I'm also adding two bug fixes:
All the affected tests are fixed as those bugs modify data expected by the test cases.
Plus: I moved some of the needless verbose messages in the SPDX package to Debug to reduce the verbosity (this is on its own commit so it should be easy to hide when reviewing)
Which issue(s) this PR fixes:
Follow-up to #342
Special notes for your reviewer:
/assign @cpanato @saschagrunert
Does this PR introduce a user-facing change?