Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook for validating powervscluster.spec.loadbalancer.additionallister.port against 6443 #1663

Closed
Karthik-K-N opened this issue Mar 14, 2024 · 3 comments · Fixed by #1746
Closed

Add webhook for validating powervscluster.spec.loadbalancer.additionallister.port against 6443 #1663

Karthik-K-N opened this issue Mar 14, 2024 · 3 comments · Fixed by #1746
Assignees
@KeerthanaAP
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.8.x

Comments

@Karthik-K-N
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

As of today by default we create loadbalancer pool and listner with port 6443.

If knowingly user tries to configure a loadbalancer with same port again it throws error

{
  "lastTransitionTime": "2024-03-11T13:54:30Z",
  "message": "Port '6443' is used by another listener instance. Please choose a different port.",
  "reason": "LoadBalancerReconciliationFailed",
  "severity": "Error",
  "status": "False",
  "type": "LoadBalancerReady"
}

So better to fail it early with the help of webhook

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Mar 14, 2024
@mkumatag mkumatag modified the milestones: v0.8, Next Mar 14, 2024
@hamzy
Copy link

hamzy commented Mar 14, 2024

Is there validation for duplicates in the list? For numbers outside of an allowed range?

@Karthik-K-N
Copy link
Contributor Author

We can plan to add it, may be even we can use kubebuilder tags to avoid them

@KeerthanaAP
Copy link
Contributor

/assign @KeerthanaAP

@KeerthanaAP KeerthanaAP mentioned this issue Apr 24, 2024
Merged
@mkumatag mkumatag modified the milestones: Next, v0.8.x May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KeerthanaAP KeerthanaAP

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.8.x
5 participants
@hamzy @mkumatag @KeerthanaAP @k8s-ci-robot @Karthik-K-N