Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IsPowerVSZoneSupportsPER() to use interface #1774

Closed
Karthik-K-N opened this issue May 14, 2024 · 3 comments · Fixed by #1775
Closed

Refactor IsPowerVSZoneSupportsPER() to use interface #1774

Karthik-K-N opened this issue May 14, 2024 · 3 comments · Fixed by #1775
Assignees
@Shilpa-Gokul
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.8

Comments

@Karthik-K-N
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Currently IsPowerVSZoneSupportsPER() is directly calling dataceter client to get details, It will be problem while implementing UT so consider refactoring it to use interfaces which will help in mocking.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels May 14, 2024
@Karthik-K-N
Copy link
Contributor Author

/assign @Shilpa-Gokul

@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: GitHub didn't allow me to assign the following users: Shilpa-Gokul.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Shilpa-Gokul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shilpa-Gokul
Copy link
Contributor

/assign @Shilpa-Gokul

@Shilpa-Gokul Shilpa-Gokul mentioned this issue May 15, 2024
Merged
@mkumatag mkumatag added this to the v0.8 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shilpa-Gokul Shilpa-Gokul

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

Refactor IsPowerVSZoneSupportsPER() code to use interface Shilpa-Gokul/cluster-api-provider-ibmcloud
4 participants
@mkumatag @k8s-ci-robot @Karthik-K-N @Shilpa-Gokul