Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failure in CAPZ w/ CAPI v1.7.0-beta.1 #10331

Closed
mboersma opened this issue Mar 27, 2024 · 5 comments
Closed

Unit test failure in CAPZ w/ CAPI v1.7.0-beta.1 #10331

mboersma opened this issue Mar 27, 2024 · 5 comments
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mboersma
Copy link
Contributor

mboersma commented Mar 27, 2024

Which jobs are failing?

N/A

Which tests are failing?

The TestASOSecretReconcile unit test in CAPZ is failing on the branch that's integrating CAPZ v1.7.0-beta.1. See kubernetes-sigs/cluster-api-provider-azure#4646 and this comment in particular.

Since when has it been failing?

Since trying to integrate CAPI v1.7.0-beta.0.

Testgrid link

No response

Reason for failure (if possible)

The reason seems to be that .GetObjectKind() returns a partially empty object.

Anything else we need to know?

No response

Label(s) to be applied

/kind failing-test

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

CAPI contributors will take a look as soon as possible, apply one of the triage/* labels and provide further guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor Author

This seems very likely related to #9956

@mboersma
Copy link
Contributor Author

/close

This change in controller-runtime is probably what caused the unit test to fail: kubernetes-sigs/controller-runtime#2633

Fixed in kubernetes-sigs/cluster-api-provider-azure@d787ca4 by not relying on the GVK having TypeMeta populated. See also #9956.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closing this issue.

In response to this:

/close

This change in controller-runtime is probably what caused the unit test to fail: kubernetes-sigs/controller-runtime#2633

Fixed in kubernetes-sigs/cluster-api-provider-azure@d787ca4 by not relying on the GVK having TypeMeta populated. See also #9956.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants