Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump to CR v0.15.0 #8007

Merged
merged 14 commits into from
May 24, 2023
Merged

⚠️ Bump to CR v0.15.0 #8007

merged 14 commits into from
May 24, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 26, 2023 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Notes:

  • PR is intentionally split into multiple commits for now to make reviewing easier

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8459

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2023
@sbueringer sbueringer changed the title [WIP] [POC] Cluster API with CR main [WIP] [POC] ⚠️ Cluster API with CR main Jan 26, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2023
@sbueringer sbueringer mentioned this pull request Apr 13, 2023
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2023
@sbueringer sbueringer force-pushed the pr-cr-v0.15 branch 2 times, most recently from 5deba93 to 15e170a Compare April 28, 2023 18:12
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
/retest

sbueringer
sbueringer commented May 2, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@sbueringer
Copy link
Member Author

Push force just modified the v1.4-to-v1.5.md doc

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-dualstack-ipv6-main 8e3456a link false /test pull-cluster-api-e2e-informing-dualstack-ipv6-main
pull-cluster-api-e2e-full-dualstack-ipv6-main ca09660 link false /test pull-cluster-api-e2e-full-dualstack-ipv6-main
pull-cluster-api-apidiff-main 06ee6fb link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jackfrancis
Copy link
Contributor

This lgtm, great work not just getting these changes up, but queuing them up for 6+ months so that it's ready to land when everything else has been done to allow this!

This was referenced May 24, 2023
Closed
Closed
@fabriziopandini
Copy link
Member

great work not just getting these changes up, but queuing them up for 6+ months so that it's ready to land when everything else has been done to allow this!

echo to this, really great work

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bda60e6faf36884a7fe8661d1c80ba9805bc2b9f

CecileRobertMichon
CecileRobertMichon reviewed May 24, 2023
View reviewed changes
docs/book/src/developer/providers/migrations/v1.4-to-v1.5.md
@@ -36,3 +39,22 @@ maintainers of providers and consumers of our Go API.
### Suggested changes for providers

-

## Notes about the controller-runtime bump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thank you for adding detailed notes here

@killianmuldoon
Copy link
Contributor

/lgtm

Just to add on top of everyone else saying this - great work! It took a lot to track this over months of underlying changes in both CAPI and controller runtime - thank you very much!

@sbueringer
Copy link
Member Author

Thx for the reviews everyone! I know it's not the most fun PR to review :)

@fabriziopandini
Copy link
Member

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 89a36ac into kubernetes-sigs:main May 24, 2023
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 24, 2023
@sbueringer sbueringer deleted the pr-cr-v0.15 branch May 25, 2023 03:51
@killianmuldoon killianmuldoon mentioned this pull request May 25, 2023
Merged
@flavio-fernandes flavio-fernandes mentioned this pull request Jun 2, 2023
Closed
@johnbelamaric johnbelamaric mentioned this pull request Jun 2, 2023
Closed
@killianmuldoon
Copy link
Contributor

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 25, 2023
@killianmuldoon killianmuldoon removed the area/clusterctl Issues or PRs related to clusterctl label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sbueringer @killianmuldoon @fabriziopandini @joekr @k8s-ci-robot @jackfrancis @CecileRobertMichon @vincepri