Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add call out for area labels when making a PR #8260

Merged

Conversation

joekr
Copy link
Member

@joekr joekr commented Mar 10, 2023

What this PR does / why we need it:
We would like users to add labels to their PRs. This will help the release team know the areas of the code base update for better release notes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Ref #8051

What type of PR is this?

/area documentation

@k8s-ci-robot
Copy link
Contributor

@joekr: The label(s) area/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
We would like users to add labels to their PRs. This will help the release team know the areas of the code base update for better release notes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Ref #8051

What type of PR is this?

/area documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2023
@joekr
Copy link
Member Author

joekr commented Mar 10, 2023

I'm not sure who to work with regarding adding labels, but we probably want to have:

  • documentation (or docs)
  • ClusterClass
  • KCP
  • we have testing but what about e2e-testing or test/e2e
  • CI
  • Server-Side-Apply (or SSA)

@oscr might have more label suggestions as well.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It's relatively easy to add and remove area labels, so it's fine to take an iterative approach there. I think, if this is the agreed upon approach, we could also add a /needs-area label to all PRs that don't have one, which gives a hint to reviewers to add the label.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5974f77948fc02f0c4db709619f817dd82496f4c

@killianmuldoon
Copy link
Contributor

@joekr Could you open an issue to discuss cleaning up the existing area labels and adding new useful ones?

/retitle 📖 Add call out for area labels when making a PR

@k8s-ci-robot k8s-ci-robot changed the title docs: add call out for area labels when making a PR 📖 Add call out for area labels when making a PR Mar 10, 2023
@sbueringer
Copy link
Member

+1 to figure out which area labels we want via an issue. I can give some input there


1. If this is your first time, please read our contributor guidelines: https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#contributing-a-patch and developer guide https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/guide.md

2. Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this go down into What type of PR is this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here, number 2 above sounds like it should go into "What type of PR is this?"


#### What type of PR is this?
<!--
Area example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Area example:
Example for adding an area label (see https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of available labels):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the call out. I forgot about this PR 😵‍💫

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 14 has this called out instead.

@joekr joekr force-pushed the update-pr-template-with-labels branch from edad9e3 to 8a70509 Compare May 25, 2023 19:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@joekr joekr force-pushed the update-pr-template-with-labels branch from 8a70509 to 39077e5 Compare May 25, 2023 19:02
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2dad8a7a0dfa20f0539a05d2c71aa884e990cb7

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
**What type of PR is this?**

<!--
Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+
Please label this pull request according to what area(s) you are addressing. For reference on PR/issue labels, see: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
We would like users to add labels to their PRs. This will help the
release team know the areas of the code base update for better
release notes.
@joekr joekr force-pushed the update-pr-template-with-labels branch from 39077e5 to 1b8cf49 Compare August 8, 2023 21:46
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@nprokopic
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb853c928c2fc89f9a7df95274699c00e92a0dd5

@killianmuldoon
Copy link
Contributor

/lgtm
/approve

/hold

for @sbueringer

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

/hold cancel

Thx!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [killianmuldoon,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 253c487 into kubernetes-sigs:main Aug 9, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants