-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add call out for area labels when making a PR #8260
📖 Add call out for area labels when making a PR #8260
Conversation
@joekr: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm not sure who to work with regarding adding labels, but we probably want to have:
@oscr might have more label suggestions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It's relatively easy to add and remove area labels, so it's fine to take an iterative approach there. I think, if this is the agreed upon approach, we could also add a /needs-area label to all PRs that don't have one, which gives a hint to reviewers to add the label.
LGTM label has been added. Git tree hash: 5974f77948fc02f0c4db709619f817dd82496f4c
|
@joekr Could you open an issue to discuss cleaning up the existing area labels and adding new useful ones? /retitle 📖 Add call out for area labels when making a PR |
+1 to figure out which area labels we want via an issue. I can give some input there |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
||
1. If this is your first time, please read our contributor guidelines: https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#contributing-a-patch and developer guide https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/guide.md | ||
|
||
2. Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this go down into What type of PR is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 here, number 2 above sounds like it should go into "What type of PR is this?"
|
||
#### What type of PR is this? | ||
<!-- | ||
Area example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Area example: | |
Example for adding an area label (see https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of available labels): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the call out. I forgot about this PR 😵💫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 14 has this called out instead.
edad9e3
to
8a70509
Compare
8a70509
to
39077e5
Compare
/lgtm |
LGTM label has been added. Git tree hash: c2dad8a7a0dfa20f0539a05d2c71aa884e990cb7
|
.github/PULL_REQUEST_TEMPLATE.md
Outdated
**What type of PR is this?** | ||
|
||
<!-- | ||
Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please label this pull request according to what area(s) you are addressing. For reference on on PR/issue labels: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+ | |
Please label this pull request according to what area(s) you are addressing. For reference on PR/issue labels, see: https://github.com/kubernetes-sigs/cluster-api/labels?q=area+ |
We would like users to add labels to their PRs. This will help the release team know the areas of the code base update for better release notes.
39077e5
to
1b8cf49
Compare
/lgtm |
LGTM label has been added. Git tree hash: bb853c928c2fc89f9a7df95274699c00e92a0dd5
|
/lgtm /hold for @sbueringer |
/lgtm /hold cancel Thx! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We would like users to add labels to their PRs. This will help the release team know the areas of the code base update for better release notes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Ref #8051
What type of PR is this?
/area documentation