Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Stop serving v1alpha3 API types #8549

Merged
merged 1 commit into from
May 23, 2023
Merged

⚠️ Stop serving v1alpha3 API types #8549

merged 1 commit into from
May 23, 2023

Conversation

killianmuldoon
Copy link
Contributor

Set served: false on v1alpha3 API types in:

  • api
  • controlplane/kubeadm/api
  • booststrap/kubeadm/api
  • test/infrastructure/docker/api

Part of #8038

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2023
@killianmuldoon killianmuldoon force-pushed the pr-stop-v1alpha3 branch 2 times, most recently from 026b83c to 2cdc496 Compare April 24, 2023 11:50
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2023
@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023 •
edited

Just took a very quick look. There should be more:

$ find . -type d -name "v1alpha3" | sort
./api/v1alpha3
./bootstrap/kubeadm/api/v1alpha3
./cmd/clusterctl/api/v1alpha3 # nothing to do here obviously
./controlplane/kubeadm/api/v1alpha3
./exp/addons/api/v1alpha3
./exp/api/v1alpha3
./test/infrastructure/docker/api/v1alpha3
./test/infrastructure/docker/exp/api/v1alpha3

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2023
@killianmuldoon killianmuldoon changed the title [WIP] ⚠️ Stop serving v1alpha3 API types ⚠️ Stop serving v1alpha3 API types May 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Copy link
Contributor Author

/area api

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label May 16, 2023
@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label May 16, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
@killianmuldoon killianmuldoon force-pushed the pr-stop-v1alpha3 branch 3 times, most recently from 23e7e62 to 7059d02 Compare May 16, 2023 16:17
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

No need to keep tagging this - I'm currently running the 0.3 migration test in PR-Informing to ensure it's passing.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@killianmuldoon killianmuldoon removed the area/api Issues or PRs related to the APIs label May 19, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Stop serving v1alpha3 API types
aeabb99 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9126dce93bb53fc1a612d09255e9b69f1a13b50

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

/hold
for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2023
fabriziopandini
fabriziopandini reviewed May 23, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the CRD migration scripts in clusterctl, Great work!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 79c9f57 into kubernetes-sigs:main May 23, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 23, 2023
@killianmuldoon killianmuldoon removed the area/clusterctl Issues or PRs related to clusterctl label Jul 25, 2023
@killianmuldoon
Copy link
Contributor Author

/area api

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@ykakarap ykakarap ykakarap left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @fabriziopandini @ykakarap