Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add a section for configuring Kubelet in Cluster API #8678

Merged
merged 1 commit into from
Jul 19, 2023
Merged

📖 Add a section for configuring Kubelet in Cluster API #8678

merged 1 commit into from
Jul 19, 2023
+356 −1

Conversation

musaprg
Copy link
Member

@musaprg musaprg commented May 16, 2023 •
edited

What this PR does / why we need it
This PR introduces a new page to describe how to configure kubelet with CAPBK.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8425

TODOs

  • Add examples
  • Add descriptions
  • Add limitations

Considerations

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @musaprg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2023
@musaprg
Copy link
Member Author

musaprg commented May 16, 2023

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 16, 2023
@killianmuldoon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2023
@killianmuldoon
Copy link
Contributor

@musaprg when this one is ready for review please take it out of draft and I'll take a look

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2023
@musaprg musaprg force-pushed the add-docs-configuring-kubelet branch from d23ba1c to c66219b Compare June 18, 2023 12:28
@musaprg musaprg marked this pull request as ready for review June 18, 2023 13:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2023
@musaprg musaprg marked this pull request as draft June 18, 2023 13:44
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2023
@musaprg musaprg marked this pull request as ready for review June 18, 2023 14:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from elmiko June 18, 2023 14:18
@musaprg
Copy link
Member Author

musaprg commented Jun 18, 2023

I'm not confident about my English, so I would greatly appreciate your feedback on any grammatical errors.

fabriziopandini
fabriziopandini reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing up this doc!
Just a couple of nits from me

Looping in docs reviewers @oscr @elmiko

docs/book/src/tasks/bootstrap/kubeadm-bootstrap/kubelet-config.md Outdated Show resolved Hide resolved
docs/book/src/tasks/bootstrap/kubeadm-bootstrap/kubelet-config.md Outdated Show resolved Hide resolved
docs/book/src/tasks/bootstrap/kubeadm-bootstrap/kubelet-config.md Outdated Show resolved Hide resolved
docs/book/src/tasks/bootstrap/kubeadm-bootstrap/kubelet-config.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023
@snstaberah
Copy link

also need this func to config kubelet args

@musaprg musaprg force-pushed the add-docs-configuring-kubelet branch from fac54d4 to 43bfc3c Compare July 11, 2023 17:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@musaprg
Copy link
Member Author

musaprg commented Jul 11, 2023

also need this func to config kubelet args

@snstaberah Which function are you referring to? It's possible that there was a permalink, but it appears to be missing.

@fabriziopandini
Copy link
Member

lgtm pending squash
cc @sbueringer @killianmuldoon

@musaprg musaprg force-pushed the add-docs-configuring-kubelet branch from 3463620 to 3ec22f5 Compare July 19, 2023 14:31
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2023
@musaprg musaprg force-pushed the add-docs-configuring-kubelet branch from 3ec22f5 to 8c510a0 Compare July 19, 2023 14:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2023
@musaprg
Add a section for configuring Kubelet in Cluster API
1018694 
Signed-off-by: Kotaro Inoue <inoue.kotaro@linecorp.com>
@musaprg musaprg force-pushed the add-docs-configuring-kubelet branch from 8c510a0 to 1018694 Compare July 19, 2023 14:35
killianmuldoon
killianmuldoon reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job - thanks for working on this @musaprg! Very clearly explained with good examples.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c209407cf8f20a46c5dbeb13bd888f4019cb7a9f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit ddbf9cf into kubernetes-sigs:main Jul 19, 2023
15 of 16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 19, 2023
@musaprg musaprg deleted the add-docs-configuring-kubelet branch July 19, 2023 14:58
@musaprg musaprg mentioned this pull request Oct 17, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@ykakarap ykakarap Awaiting requested review from ykakarap

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@elmiko elmiko Awaiting requested review from elmiko

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Docs: Configuring Kubelet in Cluster API
5 participants
@musaprg @k8s-ci-robot @killianmuldoon @snstaberah @fabriziopandini