Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add in memory provider #8799

Merged

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jun 6, 2023

What this PR does / why we need it:
Add the in-memory provider to be used for stress testing

NOTE: The code in this PR has been available for feedback at https://github.com/fabriziopandini/cluster-api-provider-goofy for some time now (and this link has been shared during the latest two office hours).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/clusterctl Issues or PRs related to clusterctl labels Jun 6, 2023
@fabriziopandini
Copy link
Member Author

cc @sbueringer

@killianmuldoon
Copy link
Contributor

Link checker issue is fine as it's just a link to a folder introduced in this PR.

Tiltfile Outdated Show resolved Hide resolved
test/infrastructure/inmemory/Dockerfile Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are publishing this file on our release. let's have a follow-up to add an actual working cluster-template here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should do some sort of alpha release to verify this all works

Copy link
Member

@sbueringer sbueringer Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are publishing this file on our release. let's have a follow-up to add an actual working cluster-template here

Probably makes sense to wait with CC support before we do this (or do it as part of implementing CC support)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the template I'm using for experimenting with the new provider.
I will open a follow-up issue to improve it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ykakarap can update it when he's working on the ClusterClass support (with a template using a CC)

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for squash

Really really great work!!!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb4a5e5a640d7cf4da10141df358d3490317b73b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@sbueringer
Copy link
Member

Merging manually to skip over the link checker

@sbueringer sbueringer merged commit 02f141d into kubernetes-sigs:main Jun 6, 2023
17 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 6, 2023
@fabriziopandini
Copy link
Member Author

Note:

  • People can still review and we'll open follow-up PRs to address potential findings.
  • This work is still at the initial stage - it is just a proof of concept ATM -; so another way to provide feedback is to follow upcoming PRs in this area (I will open issues tracking the next steps and link it here)
  • I'm also planning to propose to the community a deep dive session where I can give an overview of the internals of the new provider to everyone interested in it.

@sbueringer sbueringer mentioned this pull request Jun 7, 2023
27 tasks
@fabriziopandini fabriziopandini deleted the add-in-memory-provider branch June 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants