📖 Add Maintainer to release team roles #8988

killianmuldoon · 2023-07-11T11:57:22Z

Add a Release Writer role to the the release tasks doc. This role has become de facto required as part of the release process. This change formalizes the role and defines the responsibilities and tasks of someone who is the designated Release Writer for a release.

killianmuldoon · 2023-07-11T11:57:30Z

/area release

joekr · 2023-07-11T12:11:16Z

/lgtm

k8s-ci-robot · 2023-07-11T12:11:23Z

LGTM label has been added.

Git tree hash: 75d023e3ca78cacb519f49aa5598cea3997238de

killianmuldoon

/retitle 📖 Add Release Writer to release team roles

killianmuldoon · 2023-07-11T13:01:06Z

/hold

For feedback from the community meeting.

elmiko · 2023-07-12T17:12:15Z

we are discussing this during the community meeting on 12 July, there are some questions about this process and the name. cc @CecileRobertMichon for more comments.

re: naming, "release maintainer" as opposed to "release writer" might make this clearer

CecileRobertMichon · 2023-07-12T17:39:58Z

TLDR from the office hours discussion:

general consensus that having a maintainer available for help and support during release days is a good idea, +1 to formalize this
we should still look into giving the release team all the permissions they need to be able to release end to end without needing maintainers' help (this might mean setting up more automation, setting up a release manager team similar to k8s with a custom github role, etc.)
Preference around naming this role something like "on-call maintainer" or "supporting maintainer" so it's clear this role has to be filled by a project maintainer as opposed to something generic like "release writer"

fabriziopandini

Only a nitpick on the role name otherwise +1 for me

docs/release/release-tasks.md

sbueringer

Just nits

docs/release/release-tasks.md

docs/release/release-team.md

sbueringer · 2023-07-13T16:03:34Z

/lgtm
You'll need a rebase now though

Thx for keeping this documentation up-to-date!!!

k8s-ci-robot · 2023-07-13T16:03:40Z

LGTM label has been added.

Git tree hash: 341f271e925c22ce4a1ab1b0018e8c24c404e505

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>

sbueringer · 2023-07-14T06:45:13Z

/lgtm

Let's give others a chance to review (again). Would be good if we can get this merged within the next week or so. So we have it ready for the next cycle.

k8s-ci-robot · 2023-07-14T06:45:18Z

LGTM label has been added.

Git tree hash: c76217f83eafd32ca07abd91fea276754207145b

killianmuldoon · 2023-07-18T17:15:15Z

/hold cancel

@sbueringer WDYT about merging this as-is? If there's further feedback we can update before the next release team comes onboard.

sbueringer · 2023-07-18T17:17:09Z

Sounds good.

If there is any further feedback, please let us know and we can do a follow-up PR

/approve

k8s-ci-robot · 2023-07-18T17:17:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~docs/OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CecileRobertMichon · 2023-07-18T22:05:13Z

docs/release/releases/release-1.6.md

+| CI Signal/Bug Triage/Automation Manager   | TBD | TBD   |
+| Release Writer                            | TBD | TBD   |


sorry for the late review! this should also be renamed to Maintainer

otherwise LGTM

Thanks for catching that - opened a PR at #9013

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2023

k8s-ci-robot added area/release Issues or PRs related to releasing size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2023

k8s-ci-robot requested review from elmiko and jackfrancis July 11, 2023 11:57

killianmuldoon force-pushed the pr-add-release-writer branch from 0d96c49 to 87e98b2 Compare July 11, 2023 12:01

k8s-ci-robot assigned joekr Jul 11, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023

killianmuldoon force-pushed the pr-add-release-writer branch from 87e98b2 to bd227ef Compare July 11, 2023 12:43

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023

k8s-ci-robot requested a review from joekr July 11, 2023 12:43

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2023

killianmuldoon force-pushed the pr-add-release-writer branch 4 times, most recently from 462fb9b to 4e0de00 Compare July 11, 2023 12:56

killianmuldoon commented Jul 11, 2023

View reviewed changes

k8s-ci-robot changed the title ~~[WIP] 📖 Add Release Writer to release team roles~~ 📖 Add Release Writer to release team roles Jul 11, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023

killianmuldoon force-pushed the pr-add-release-writer branch from 4e0de00 to 0a0b744 Compare July 11, 2023 13:04

fabriziopandini reviewed Jul 12, 2023

View reviewed changes

docs/release/release-tasks.md Outdated Show resolved Hide resolved

sbueringer reviewed Jul 13, 2023

View reviewed changes

docs/release/release-team.md Outdated Show resolved Hide resolved

docs/release/release-team.md Outdated Show resolved Hide resolved

killianmuldoon force-pushed the pr-add-release-writer branch from 0a0b744 to efd8996 Compare July 13, 2023 15:35

k8s-ci-robot assigned sbueringer Jul 13, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023

Add Release Writer to release team roles

caf6095

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>

killianmuldoon force-pushed the pr-add-release-writer branch from efd8996 to caf6095 Compare July 13, 2023 16:06

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023

k8s-ci-robot requested a review from sbueringer July 13, 2023 16:06

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023

sbueringer changed the title ~~📖 Add Release Writer to release team roles~~ 📖 Add Maintainer to release team roles Jul 14, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023

k8s-ci-robot merged commit 13d90f9 into kubernetes-sigs:main Jul 18, 2023
20 of 21 checks passed

k8s-ci-robot added this to the v1.6 milestone Jul 18, 2023

CecileRobertMichon reviewed Jul 18, 2023

View reviewed changes

killianmuldoon mentioned this pull request Jul 18, 2023

📖 Fix role names in release docs #9013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📖 Add Maintainer to release team roles #8988

📖 Add Maintainer to release team roles #8988

killianmuldoon commented Jul 11, 2023

killianmuldoon commented Jul 11, 2023

joekr commented Jul 11, 2023

k8s-ci-robot commented Jul 11, 2023

killianmuldoon left a comment

killianmuldoon commented Jul 11, 2023

elmiko commented Jul 12, 2023 •

edited

CecileRobertMichon commented Jul 12, 2023

fabriziopandini left a comment

sbueringer left a comment

sbueringer commented Jul 13, 2023 •

edited

k8s-ci-robot commented Jul 13, 2023

sbueringer commented Jul 14, 2023 •

edited

k8s-ci-robot commented Jul 14, 2023

killianmuldoon commented Jul 18, 2023 •

edited

sbueringer commented Jul 18, 2023

k8s-ci-robot commented Jul 18, 2023

CecileRobertMichon Jul 18, 2023

killianmuldoon Jul 18, 2023

		\| CI Signal/Bug Triage/Automation Manager \| TBD \| TBD \|
		\| Release Writer \| TBD \| TBD \|

📖 Add Maintainer to release team roles #8988

📖 Add Maintainer to release team roles #8988

Conversation

killianmuldoon commented Jul 11, 2023

killianmuldoon commented Jul 11, 2023

joekr commented Jul 11, 2023

k8s-ci-robot commented Jul 11, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

killianmuldoon commented Jul 11, 2023

elmiko commented Jul 12, 2023 • edited

CecileRobertMichon commented Jul 12, 2023

fabriziopandini left a comment

Choose a reason for hiding this comment

sbueringer left a comment

Choose a reason for hiding this comment

sbueringer commented Jul 13, 2023 • edited

k8s-ci-robot commented Jul 13, 2023

sbueringer commented Jul 14, 2023 • edited

k8s-ci-robot commented Jul 14, 2023

killianmuldoon commented Jul 18, 2023 • edited

sbueringer commented Jul 18, 2023

k8s-ci-robot commented Jul 18, 2023

CecileRobertMichon Jul 18, 2023

Choose a reason for hiding this comment

killianmuldoon Jul 18, 2023

Choose a reason for hiding this comment

elmiko commented Jul 12, 2023 •

edited

sbueringer commented Jul 13, 2023 •

edited

sbueringer commented Jul 14, 2023 •

edited

killianmuldoon commented Jul 18, 2023 •

edited