Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Move internal.labels to format package for use by providers #9002

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jul 14, 2023

What this PR does / why we need it: We need capilabels.MustFormatValue() to be available for providers implementing MachinePool Machines.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2023
@sbueringer
Copy link
Member

Opened a PR against your branch to fix the circular dependency: Jont828#1

@sbueringer sbueringer changed the title Move internal.labels package to util for use by providers 馃尡 Move internal.labels package to util for use by providers Jul 14, 2023
@sbueringer
Copy link
Member

sbueringer commented Jul 14, 2023

I'm not sure if that technically falls under our backport guidelines post code freeze but I think it 100% makes sense to cherry-pick this into release-1.5.

With the MPM implemention we advice InfraMachinePool implementers to use thoes utils, but this will only be possible if the utils are actually public. So I guess we can consider this sort of a bug fix.

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

I'm not sure if that technically falls under our backport guidelines post-code freeze but I think it 100% makes sense to cherry-pick this into release-1.5.

With the MPM implemention we advice folks to use thoes utils, but this will only be possible if the utils are actually public. So I guess we can consider this sort of a bug fix.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2023
@sbueringer
Copy link
Member

/lgtm

approve pending squash

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22d41546017ca914eed2318609d162b0ad612408

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Also fine with this being made available in v1.5.

@Jont828 Jont828 changed the title 馃尡 Move internal.labels package to util for use by providers 馃尡 Move internal.labels to format package for use by providers Jul 17, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03aba9c66508bbbf6341181d05d432a743d970a7

@k8s-ci-robot k8s-ci-robot merged commit 10d44b6 into kubernetes-sigs:main Jul 17, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 17, 2023
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #9006

In response to this:

I'm not sure if that technically falls under our backport guidelines post code freeze but I think it 100% makes sense to cherry-pick this into release-1.5.

With the MPM implemention we advice InfraMachinePool implementers to use thoes utils, but this will only be possible if the utils are actually public. So I guess we can consider this sort of a bug fix.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johannesfrey
Copy link
Contributor

/area api

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jul 18, 2023
@killianmuldoon
Copy link
Contributor

/area util

@k8s-ci-robot k8s-ci-robot added the area/util Issues or PRs related to utils label Jul 18, 2023
@killianmuldoon killianmuldoon removed the area/api Issues or PRs related to the APIs label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants