Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 ClusterCacheTracker: ensure Get/List calls are not getting stuck when apiserver is unreachable #9028

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 21, 2023

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8948 (comment)

… apiserver is unreachable

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2023
@sbueringer
Copy link
Member Author

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 56eab3e62a57e497b55a74f1da18832cd558c2ff

@Levi080513
Copy link
Contributor

This PR will indeed solve #8948, thank you very much @sbueringer

@sbueringer
Copy link
Member Author

This PR will indeed solve #8948, thank you very much @sbueringer

Thx for verifying!

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 20f9b5f into kubernetes-sigs:main Jul 21, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 21, 2023
@killianmuldoon
Copy link
Contributor

If I'm reading the issue right this should be cherry-picked to both release-1.5 and release-1.4. Is that right @sbueringer

@sbueringer
Copy link
Member Author

sbueringer commented Jul 21, 2023

To all supported branches if possible. Just needs manual cherrypicks for most branches will work on that in a bit

@sbueringer
Copy link
Member Author

sbueringer commented Jul 21, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@sbueringer: cannot checkout realease-1.5: error checking out realease-1.5: exit status 1. output: error: pathspec 'realease-1.5' did not match any file(s) known to git

In response to this:

/cherry-pick realease-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #9030

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

/area clustercachetracker

@k8s-ci-robot k8s-ci-robot added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KCP reconcile hang the when workload cluster API Server is unreachable
8 participants