馃尡 Improve multiple areas PRs with user friendly subs #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/release
g-gaston
force-pushed
the
release-notes-mutliple-areas-subs
branch
from
1c307da
to
e182064
Compare
|
/retest |
sbueringer
reviewed
Jul 25, 2023
k8s-ci-robot
added
the
needs-rebase
This applies the same user friendly areas substitutions to the multiple areas entries that it was already applied to single area entries. As a bonus, add a case insensitive string sorting that avoids exponential string allocation.
g-gaston
force-pushed
the
release-notes-mutliple-areas-subs
branch
from
e182064
to
333b213
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cd019b9c1747c9f94a5409255a31f35fa923455f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This applies the same user friendly areas substitutions to the multiple areas entries that it was already applied to single area entries.
As a bonus, add a case insensitive string sorting that avoids exponential string allocation. There was no major issue with the previous implementation, I just already had this one lying around and it should be a bit more efficient. This is mostly because strings are immutable in Go, so any
ToLowercall would basically have to allocate memory for a new string.Which issue(s) this PR fixes:
Part of #9008
/area release