Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add v1.6 Release Team members' GitHub/Slack handles #9087

Merged
merged 1 commit into from
Jul 31, 2023
Merged

📖 Add v1.6 Release Team members' GitHub/Slack handles #9087

merged 1 commit into from
Jul 31, 2023

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jul 28, 2023 •
edited

What this PR does / why we need it:

  • Fixes formatting issues in the table
  • adds v1.6 Release Team members GitHub/Slack handles in an alphabetical order

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2023
@furkatgofurov7
Copy link
Member Author

/cc @vincepri @sbueringer @CecileRobertMichon PTAL

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vincepri @sbueringer @CecileRobertMichon PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Jul 28, 2023 •
edited

Just one nit otherwise lgtm

/assign @vincepri
(as the "maintainer" :))

@furkatgofurov7 furkatgofurov7 force-pushed the add-rt1-6-members branch 2 times, most recently from 655969e to e457207 Compare July 31, 2023 07:48
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a7876669b25425c84050a61f2894286c5fcb15b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@furkatgofurov7
Copy link
Member Author

/check cla

@furkatgofurov7
Copy link
Member Author

/check-cla

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Jul 31, 2023 •
edited

It has already cla label but EasyCLA looks to be stuck for some unknown reason.. perhaps I need to force push?

@sbueringer
Copy link
Member

sbueringer commented Jul 31, 2023 •
edited

You can ignore it. We have this across multiple repos and I noticed that the action doesn't block Tide from merging

@sbueringer
Copy link
Member

/test pull-cluster-api-build-main

@furkatgofurov7
Copy link
Member Author

You can ignore it. We have this across multiple repos and I noticed that the action doesn't block Tide from merging

It is still not letting it in 🤷🏼‍♂️

/retest

@sbueringer
Copy link
Member

Hm yeah. Can you commit --amend & push --force?

Not sure what's going on with the merge pool

@furkatgofurov7
Add v1.6 Release Team members GitHub/Slack handles
1179994 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Member Author

Hm yeah. Can you commit --amend & push --force?

Not sure what's going on with the merge pool

It has already cla label but EasyCLA looks to be stuck for some unknown reason.. perhaps I need to force push?

I already did, but force pushed it again now, let's see. Looks like a prow issue to me

@furkatgofurov7
Copy link
Member Author

/retest-required

@furkatgofurov7
Copy link
Member Author

/check-cla

@sbueringer
Copy link
Member

sbueringer commented Jul 31, 2023 •
edited

The strange thing is: "Tide in merge pool".

I merged several PRs today where the GitHub action was pending, that was not an issue (btw there is the upstream issue for that: communitybridge/easycla#4071)

@sbueringer
Copy link
Member

But looking at the Prow UI. I don't see a merge pool for CAPI including this PR.

Can you reopen this PR? (close this one and create a new separate one)

@sbueringer
Copy link
Member

/easycla

@k8s-ci-robot k8s-ci-robot merged commit 1f5fcd2 into kubernetes-sigs:main Jul 31, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 31, 2023
@sbueringer
Copy link
Member

Interesting. Looks like this blocked it still somehow

@furkatgofurov7
Copy link
Member Author

/easycla

so this was the trick? sorry missed your comments. Thanks anyways for help!

@furkatgofurov7 furkatgofurov7 deleted the add-rt1-6-members branch July 31, 2023 18:07
@sbueringer
Copy link
Member

sbueringer commented Aug 1, 2023 •
edited

/easycla

so this was the trick? sorry missed your comments. Thanks anyways for help!

I didn't think that would help to be honest. Not sure what exactly was going on. I was able to merge PRs in other repos which were in the exact same state. The only thing different here was the "Tide in merge pool" thing. But at this stage CLA shouldn't block afaik.

I just retriggered the cla as they mentioned on communitybridge/easycla#4071 that they fixed the CLA issue

@furkatgofurov7 furkatgofurov7 mentioned this pull request Aug 1, 2023
Closed
29 tasks
killianmuldoon
killianmuldoon reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Aug 4, 2023
@jarias-lfx jarias-lfx mentioned this pull request Aug 21, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@ykakarap ykakarap Awaiting requested review from ykakarap

@vincepri vincepri Awaiting requested review from vincepri

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@vincepri vincepri

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@furkatgofurov7 @k8s-ci-robot @sbueringer @killianmuldoon @vincepri