馃尡 Set controller-runtime logger for clusterctl #9107
Conversation
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: eeadeafe4683906ad536d73f3e962e99b25f93a5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -163,7 +164,9 @@ func initConfig() { | |||
| } | |||
| } | |||
|
|
|||
| logf.SetLogger(logf.NewLogger(logf.WithThreshold(verbosity))) | |||
| log := logf.NewLogger(logf.WithThreshold(verbosity)) | |||
There was a problem hiding this comment.
Nice one! (de-encapsulate to encapsulate it again later :))
There was a problem hiding this comment.
I just extracted the statement we had before :) (didn't really think about it)
|
/hold cancel User confirmed that this fixed their issue. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/cherry-pick release-1.5 |
|
@killianmuldoon: new pull request created: #9129 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| logf.SetLogger(logf.NewLogger(logf.WithThreshold(verbosity))) | ||
| log := logf.NewLogger(logf.WithThreshold(verbosity)) | ||
| logf.SetLogger(log) | ||
| ctrl.SetLogger(log) |
There was a problem hiding this comment.
Unfortunately missed it until after the release :) But yup worked.
I wonder in how many binaries / controllers this "panic" will pop up :D
There was a problem hiding this comment.
True, but it's doing what it's supposed to do 馃槃
|
/area logging |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9101