Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update actions for 1.5 and make names consistent #9115

Merged

Conversation

killianmuldoon
Copy link
Contributor

Update actions for the release-1.5 branch - this was missed as part of creating the release branch initially, but is documented in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-tasks.md#tasks-2

This PR also updates the names of the github actions run on the repo to clarify which are run on PRs and which are periodic weekly jobs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 3, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Aug 3, 2023
@killianmuldoon killianmuldoon changed the title Update actions for 1.5 and make names consistent :see Update actions for 1.5 and make names consistent Aug 3, 2023
@killianmuldoon killianmuldoon changed the title :see Update actions for 1.5 and make names consistent 🌱 Update actions for 1.5 and make names consistent Aug 3, 2023
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching this

.github/workflows/pr-golangci-lint.yml Outdated Show resolved Hide resolved
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching this

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2023
@sbueringer
Copy link
Member

@killianmuldoon we're going to need something similar for CAPV :)

@killianmuldoon
Copy link
Contributor Author

we're going to need something similar for CAPV :)

I'll take a look

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60c330528e48738c39fefd01c5dff5720372b52e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit c10e104 into kubernetes-sigs:main Aug 4, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants