Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Add ClusterClass column to Cluster CRD #9120

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 4, 2023

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:
Adds a ClusterClass column to the Cluster CRD. Super helpful to determine if a Cluster is a classy cluster, and if yes which ClusterClass it uses

k get clusterclass,cluster,kcp,md
NAME                                        AGE
clusterclass.cluster.x-k8s.io/quick-start   5m44s

NAME                                       CLUSTERCLASS   PHASE         AGE     VERSION
cluster.cluster.x-k8s.io/capi-quickstart                  Provisioned   5m50s
cluster.cluster.x-k8s.io/my-cluster        quick-start    Provisioned   5m41s   v1.26.0

NAME                                                                              CLUSTER           INITIALIZED   API SERVER AVAILABLE   REPLICAS   READY   UPDATED   UNAVAILABLE   AGE     VERSION
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/capi-quickstart-control-plane   capi-quickstart   true                                 1                  1         1             5m50s   v1.25.0
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/my-cluster-465k6                my-cluster        true                                 1                  1         1             5m41s   v1.26.0

NAME                                                                        CLUSTER           REPLICAS   READY   UPDATED   UNAVAILABLE   PHASE       AGE     VERSION
machinedeployment.cluster.x-k8s.io/capi-quickstart-md-0                     capi-quickstart   1                  1         1             ScalingUp   5m50s   v1.25.0
machinedeployment.cluster.x-k8s.io/my-cluster-default-worker-topo-1-qsrp5   my-cluster        1                  1         1             ScalingUp   5m40s   v1.26.0
machinedeployment.cluster.x-k8s.io/my-cluster-default-worker-topo-2-gx42r   my-cluster        1                  1         1             ScalingUp   5m40s   v1.26.0
machinedeployment.cluster.x-k8s.io/my-cluster-default-worker-topo-3-jmwvt   my-cluster        1                  1         1             ScalingUp   5m40s   v1.26.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@killianmuldoon
Copy link
Contributor

/area api

(just barely)

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Aug 4, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Feel free to unhold - just in case anyone else wants to take a look as it's an API change.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 250588dc8844c2aaacdef07428f470d01c01b95e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Aug 4, 2023

Debatable if the columns of the CRD are an API :D

But let's not go there. Thx for the review, I'll keep it open for a few days, I'm not in a rush

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7c6cd42 into kubernetes-sigs:main Aug 8, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 8, 2023
@sbueringer sbueringer deleted the pr-add-cc branch August 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants