🐛 Fix ClusterClass enqueue for ExtensionConfig #9133
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
k8s-ci-robot
added
cncf-cla: yes
|
/cherry-pick release-1.5 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.4 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f8dfe6f966ae3f719ab92ae2a863effa66c581ef
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@killianmuldoon: new pull request created: #9137 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@killianmuldoon: new pull request created: #9138 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix the ClusterClass enqueuing behaviour for ExtensionConfigs. Currently this function can never work as it returns the name of the ExtensionConfig rather than the ClusterClass. This triggers a reconcile which always returns an "object not found error"
c/f #8495 (comment)