Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Remove previously deprecated code #9136

Merged
merged 3 commits into from
Aug 9, 2023
Merged

馃尡 Remove previously deprecated code #9136

merged 3 commits into from
Aug 9, 2023

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
follows https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-tasks.md#track-remove-previously-deprecated-code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of: #9094

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2023
killianmuldoon
killianmuldoon reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f471564fc436753f1a6a72449b49e9f34862fab

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@furkatgofurov7
Copy link
Member Author

Thanks!

I had to fix a typo in the markdown, and label was lost after a force push. PTAL once again, thank you.

vincepri
vincepri reviewed Aug 7, 2023
View reviewed changes
cmd/clusterctl/client/cluster/cert_manager.go Outdated
Comment on lines 352 to 356
if !ok {
currentVersion = "v0.11.0"
needUpgrade = true
break
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic after this commit has changed though; now we're always defaulting to v0.11.0 if the annotation isn't there; which might be ok. @fabriziopandini is this what we want to do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincepri @fabriziopandini based on the conversation above, I reverted this logic and annotation removing back and we can discuss the migration code for it in #9145 as @killianmuldoon suggested.

This was referenced Aug 4, 2023
Closed
Open
@furkatgofurov7
Remove deprecated code in v1.6
229e7ae 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Update v1.5-v1.6 migration doc with deprecated code information
e851cef 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Fix lint reported issue
ee574d9 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main ee574d9 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

killianmuldoon
killianmuldoon reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9df4da3db35c8f8c9a386e57525294592496eee

@sbueringer
Copy link
Member

Thx!

/lgtm

/assign @vincepri

Jont828
Jont828 reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furkatgofurov7
Copy link
Member Author

@kubernetes-sigs/cluster-api-release-team

vincepri
vincepri approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit dc57d8d into kubernetes-sigs:main Aug 9, 2023
19 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 9, 2023
@furkatgofurov7 furkatgofurov7 deleted the deprecated-code-1-6 branch August 9, 2023 17:59
@g-gaston
Copy link
Contributor

/area core

@k8s-ci-robot
Copy link
Contributor

@g-gaston: The label(s) area/core cannot be applied, because the repository doesn't have them.

In response to this:

/area core

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@g-gaston
Copy link
Contributor

/area util

@k8s-ci-robot k8s-ci-robot added the area/util Issues or PRs related to utils label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Jont828 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

@sbueringer sbueringer

@Jont828 Jont828

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@furkatgofurov7 @k8s-ci-robot @sbueringer @g-gaston @vincepri @Jont828 @killianmuldoon