🌱 Add colored-line-number output for golangci-lint action #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/area ci /hold To ensure this works as expected on kubernetes-sigs/cluster-api-provider-vsphere#2180 |
k8s-ci-robot
added
do-not-merge/hold
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f426e15a366bd9255e79ebdb79c4e6a92357ea11
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
pr-add-golangci-lint-output
branch
from
a687960
to
3ffaf3e
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-add-golangci-lint-output
branch
from
3ffaf3e
to
bdadb8a
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/hold cancel Looks like this is working as expected over on the CAPV repo. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
+1 to keep consistency cross repos |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 078e1603edc291e9c03cae0b29365a335fbaa816
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the colored-line-number output format for the golangci-lint action run in CI.
Idea taken from kubernetes-sigs/cluster-api-provider-vsphere#2180.