✨ v1.28: Prepare quickstart, capd and tests for the new release including kind bump #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
This was referenced Aug 10, 2023
chrischdi
force-pushed
the
pr-1-28-quickstart-capd
branch
from
dd6e89c
to
d6b2173
Compare
k8s-ci-robot
added
size/M
chrischdi
commented
Aug 14, 2023
sbueringer
reviewed
Aug 14, 2023
chrischdi
force-pushed
the
pr-1-28-quickstart-capd
branch
from
d6b2173
to
7da8e99
Compare
There was a problem hiding this comment.
One early nit - let's change from the breaking symbol in the header to a ✨ - @sbueringer mentioned this when we were drafting the most recent CAPI release notes.
|
So far so good. I'll take another look once 1.28 and (probably) kind is out, etc. |
chrischdi
commented
Aug 14, 2023
chrischdi
changed the title
chrischdi
force-pushed
the
pr-1-28-quickstart-capd
branch
from
7da8e99
to
5350e79
Compare
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main |
|
/retitle ✨ v1.28: Prepare quickstart, capd and tests for the new release including kind bump |
k8s-ci-robot
changed the title
This shouldn't be it because the MachinePool should use the same image as KCP/MD (but looks like it doesn't) EDIT: Ah sorry, Kubelet vs Machine version.. |
|
@chrischdi WDYT about extending our collection stuff to also collect Nodes from the workload cluster? (and not only kube-system pods) In any case I would have expected that MachinePools are using our self-built kind image and that it actually also uses |
Jep that sounds great.
You're totally right. The MachinePool Machines seems to have run the v1.28.0 image: curl -s --output - https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9160/pull-cluster-api-e2e-workload-upgrade-1-27-latest-main/1691763868927266816/artifacts/clusters/k8s-upgrade-and-conformance-rjzpyt/machine-pools/k8s-upgrade-and-conformance-rjzpyt-mp-0/k8s-upgrade-and-conformance-rjzpyt-worker-16nsza/kubelet-version.txt
Kubernetes v1.28.0Its also visible that the The MachinePool and DockerMachinePool look correct though... I'll take a look at it tomorrow. Also started the same test on a different branch/PR (#9209) to see if it is even caused by this PR. |
|
Sounds good! Probably the quickest way to figure this one out is to just run it locally I think it should be this PR as we should have a corresponding periodic which is green. But doesn't hurt to try |
|
My bet is on the kind mapper btw! |
|
It's reproducible locally with tilt-up + the following cluster + machinepool (which is from the failed test above): apiVersion: cluster.x-k8s.io/v1beta1
kind: ClusterClass
metadata:
name: quick-start
namespace: default
spec:
controlPlane:
machineHealthCheck:
maxUnhealthy: 100%
unhealthyConditions:
- status: "False"
timeout: 20s
type: e2e.remediation.condition
machineInfrastructure:
ref:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
name: quick-start-control-plane
metadata:
annotations:
ClusterClass.controlPlane.annotation: ClusterClass.controlPlane.annotationValue
labels:
ClusterClass.controlPlane.label: ClusterClass.controlPlane.labelValue
ref:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
name: quick-start-control-plane
infrastructure:
ref:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerClusterTemplate
name: quick-start-cluster
patches:
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/loadBalancer
valueFrom:
template: |
imageRepository: {{ .lbImageRepository }}
selector:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerClusterTemplate
matchResources:
infrastructureCluster: true
name: lbImageRepository
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/clusterConfiguration/etcd
valueFrom:
template: |
local:
imageTag: {{ .etcdImageTag }}
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Sets tag to use for the etcd image in the KubeadmControlPlane.
name: etcdImageTag
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/clusterConfiguration/dns
valueFrom:
template: |
imageTag: {{ .coreDNSImageTag }}
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Sets tag to use for the etcd image in the KubeadmControlPlane.
name: coreDNSImageTag
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/customImage
valueFrom:
template: |
kindest/node:{{ .builtin.machineDeployment.version | replace "+" "_" }}
selector:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
matchResources:
machineDeploymentClass:
names:
- default-worker
- jsonPatches:
- op: add
path: /spec/template/spec/customImage
valueFrom:
template: |
kindest/node:{{ .builtin.controlPlane.version | replace "+" "_" }}
selector:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
matchResources:
controlPlane: true
description: Sets the container image that is used for running dockerMachines
for the controlPlane and default-worker machineDeployments.
name: customImage
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/preLoadImages
valueFrom:
variable: preLoadImages
selector:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
matchResources:
controlPlane: true
machineDeploymentClass:
names:
- default-worker
description: |
Sets the container images to preload to the node that is used for running dockerMachines.
This is especially required for self-hosted e2e tests to ensure the required controller images to be available
and reduce load to public registries.
name: preloadImages
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/rolloutStrategy/rollingUpdate/maxSurge
valueFrom:
template: '{{ .kubeadmControlPlaneMaxSurge }}'
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Sets the maxSurge value used for rolloutStrategy in the KubeadmControlPlane.
enabledIf: '{{ ne .kubeadmControlPlaneMaxSurge "" }}'
name: kubeadmControlPlaneMaxSurge
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/initConfiguration/nodeRegistration/taints
value: []
- op: add
path: /spec/template/spec/kubeadmConfigSpec/joinConfiguration/nodeRegistration/taints
value: []
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
enabledIf: '{{ not .controlPlaneTaint }}'
name: controlPlaneTaint
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/joinConfiguration/nodeRegistration/kubeletExtraArgs
value:
cloud-provider: external
- op: add
path: /spec/template/spec/kubeadmConfigSpec/initConfiguration/nodeRegistration/kubeletExtraArgs
value:
cloud-provider: external
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Configures kubelet to run with an external cloud provider for control
plane nodes.
enabledIf: '{{ .externalCloudProvider }}'
name: controlPlaneExternalCloudProvider
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/joinConfiguration/nodeRegistration/kubeletExtraArgs
value:
cloud-provider: external
selector:
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: KubeadmConfigTemplate
matchResources:
machineDeploymentClass:
names:
- '*-worker'
description: Configures kubelet to run with an external cloud provider for machineDeployment
nodes.
enabledIf: '{{ .externalCloudProvider }}'
name: machineDeploymentExternalCloudProvider
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/initConfiguration/localAPIEndpoint
value:
advertiseAddress: '::'
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Configures KCP to use IPv6 for its localAPIEndpoint.
enabledIf: '{{ .ipv6Primary }}'
name: localEndpointIPv6
- definitions:
- jsonPatches:
- op: add
path: /spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer/extraArgs
value:
admission-control-config-file: /etc/kubernetes/kube-apiserver-admission-pss.yaml
- op: add
path: /spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer/extraVolumes
value:
- hostPath: /etc/kubernetes/kube-apiserver-admission-pss.yaml
mountPath: /etc/kubernetes/kube-apiserver-admission-pss.yaml
name: admission-pss
pathType: File
readOnly: true
- op: add
path: /spec/template/spec/kubeadmConfigSpec/files
valueFrom:
template: |
- content: |
apiVersion: apiserver.config.k8s.io/v1
kind: AdmissionConfiguration
plugins:
- name: PodSecurity
configuration:
apiVersion: pod-security.admission.config.k8s.io/v1{{ if semverCompare "< v1.25" .builtin.controlPlane.version }}beta1{{ end }}
kind: PodSecurityConfiguration
defaults:
enforce: "baseline"
enforce-version: "latest"
audit: "baseline"
audit-version: "latest"
warn: "baseline"
warn-version: "latest"
exemptions:
usernames: []
runtimeClasses: []
namespaces: [kube-system]
path: /etc/kubernetes/kube-apiserver-admission-pss.yaml
selector:
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
matchResources:
controlPlane: true
description: Adds an admission configuration for PodSecurity to the kube-apiserver.
enabledIf: '{{ semverCompare ">= v1.24" .builtin.controlPlane.version }}'
name: podSecurityStandard
variables:
- name: lbImageRepository
required: true
schema:
openAPIV3Schema:
default: kindest
type: string
- name: etcdImageTag
required: true
schema:
openAPIV3Schema:
default: ""
description: etcdImageTag sets the tag for the etcd image.
example: 3.5.3-0
type: string
- name: coreDNSImageTag
required: true
schema:
openAPIV3Schema:
default: ""
description: coreDNSImageTag sets the tag for the coreDNS image.
example: v1.8.5
type: string
- name: kubeadmControlPlaneMaxSurge
required: false
schema:
openAPIV3Schema:
default: ""
description: kubeadmControlPlaneMaxSurge is the maximum number of control
planes that can be scheduled above or under the desired number of control
plane machines.
example: "0"
type: string
- name: preLoadImages
required: false
schema:
openAPIV3Schema:
default: []
description: preLoadImages sets the images for the docker machines to preload.
items:
type: string
type: array
- name: controlPlaneTaint
required: false
schema:
openAPIV3Schema:
default: true
type: boolean
- name: externalCloudProvider
required: false
schema:
openAPIV3Schema:
default: false
type: boolean
- name: ipv6Primary
required: false
schema:
openAPIV3Schema:
default: false
type: boolean
workers:
machineDeployments:
- class: default-worker
machineHealthCheck:
maxUnhealthy: 100%
unhealthyConditions:
- status: "False"
timeout: 20s
type: e2e.remediation.condition
template:
bootstrap:
ref:
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: KubeadmConfigTemplate
name: quick-start-default-worker-bootstraptemplate
infrastructure:
ref:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
name: quick-start-default-worker-machinetemplate
metadata:
annotations:
ClusterClass.machineDeployment.annotation: ClusterClass.machineDeployment.annotationValue
labels:
ClusterClass.machineDeployment.label: ClusterClass.machineDeployment.labelValue
---
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerClusterTemplate
metadata:
annotations:
InfrastructureClusterTemplate.annotation: InfrastructureClusterTemplate.annotationValue
labels:
InfrastructureClusterTemplate.label: InfrastructureClusterTemplate.labelValue
name: quick-start-cluster
namespace: default
spec:
template:
metadata:
annotations:
InfrastructureClusterTemplate.template.annotation: InfrastructureClusterTemplate.template.annotationValue
labels:
InfrastructureClusterTemplate.template.label: InfrastructureClusterTemplate.template.labelValue
spec:
failureDomains:
fd1:
controlPlane: true
fd2:
controlPlane: true
fd3:
controlPlane: true
fd4:
controlPlane: false
fd5:
controlPlane: false
fd6:
controlPlane: false
fd7:
controlPlane: false
fd8:
controlPlane: false
---
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlaneTemplate
metadata:
annotations:
ControlPlaneTemplate.annotation: ControlPlaneTemplate.annotationValue
labels:
ControlPlaneTemplate.label: ControlPlaneTemplate.labelValue
name: quick-start-control-plane
namespace: default
spec:
template:
metadata:
annotations:
ControlPlaneTemplate.template.annotation: ControlPlaneTemplate.template.annotationValue
labels:
ControlPlaneTemplate.template.label: ControlPlaneTemplate.template.labelValue
spec:
kubeadmConfigSpec:
clusterConfiguration:
apiServer:
certSANs:
- localhost
- host.docker.internal
- '::'
- ::1
- 127.0.0.1
- 0.0.0.0
controllerManager:
extraArgs:
enable-hostpath-provisioner: "true"
initConfiguration:
nodeRegistration:
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
machineTemplate:
metadata:
annotations:
ControlPlaneTemplate.machineTemplate.annotation: ControlPlaneTemplate.machineTemplate.annotationValue
labels:
ControlPlaneTemplate.machineTemplate.label: ControlPlaneTemplate.machineTemplate.labelValue
nodeDrainTimeout: 1s
rolloutBefore:
certificatesExpiryDays: 21
---
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
metadata:
annotations:
InfraMachineTemplate.controlPlane.annotation: InfraMachineTemplate.controlPlane.annotationValue
labels:
InfraMachineTemplate.controlPlane.label: InfraMachineTemplate.controlPlane.labelValue
name: quick-start-control-plane
namespace: default
spec:
template:
metadata:
annotations:
InfraMachineTemplate.controlPlane.template.annotation: InfraMachineTemplate.controlPlane.template.annotationValue
labels:
InfraMachineTemplate.controlPlane.template.label: InfraMachineTemplate.controlPlane.template.labelValue
spec:
extraMounts:
- containerPath: /var/run/docker.sock
hostPath: /var/run/docker.sock
---
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
metadata:
annotations:
InfraMachineTemplate.machineDeployment.annotation: InfraMachineTemplate.machineDeployment.annotationValue
labels:
InfraMachineTemplate.machineDeployment.label: InfraMachineTemplate.machineDeployment.labelValue
name: quick-start-default-worker-machinetemplate
namespace: default
spec:
template:
metadata:
annotations:
InfraMachineTemplate.machineDeployment.template.annotation: InfraMachineTemplate.machineDeployment.template.annotationValue
labels:
InfraMachineTemplate.machineDeployment.template.label: InfraMachineTemplate.machineDeployment.template.labelValue
spec:
extraMounts:
- containerPath: /var/run/docker.sock
hostPath: /var/run/docker.sock
---
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: KubeadmConfigTemplate
metadata:
annotations:
BootstrapConfigTemplate.machineDeployment.annotation: BootstrapConfigTemplate.machineDeployment.annotationValue
labels:
BootstrapConfigTemplate.machineDeployment.label: BootstrapConfigTemplate.machineDeployment.labelValue
name: quick-start-default-worker-bootstraptemplate
namespace: default
spec:
template:
metadata:
annotations:
BootstrapConfigTemplate.machineDeployment.template.annotation: BootstrapConfigTemplate.machineDeployment.template.annotationValue
labels:
BootstrapConfigTemplate.machineDeployment.template.label: BootstrapConfigTemplate.machineDeployment.template.labelValue
spec:
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
---
apiVersion: v1
binaryData: null
data:
resources: |
# kindnetd networking manifest
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: kindnet
rules:
- apiGroups:
- ""
resources:
- nodes
verbs:
- list
- watch
- patch
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: kindnet
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: kindnet
subjects:
- kind: ServiceAccount
name: kindnet
namespace: kube-system
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: kindnet
namespace: kube-system
---
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: kindnet
namespace: kube-system
labels:
tier: node
app: kindnet
k8s-app: kindnet
spec:
selector:
matchLabels:
app: kindnet
template:
metadata:
labels:
tier: node
app: kindnet
k8s-app: kindnet
spec:
hostNetwork: true
tolerations:
- operator: Exists
effect: NoSchedule
serviceAccountName: kindnet
containers:
- name: kindnet-cni
image: kindest/kindnetd:v20230511-dc714da8
env:
- name: HOST_IP
valueFrom:
fieldRef:
fieldPath: status.hostIP
- name: POD_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
# We're using the dualstack CIDRs here. The order doesn't matter for kindnet as the loops are run concurrently.
# REF: https://github.com/kubernetes-sigs/kind/blob/3dbeb894e3092a336ab4278d3823e73a1d66aff7/images/kindnetd/cmd/kindnetd/main.go#L149-L175
- name: POD_SUBNET
value: '192.168.0.0/16,fd00:100:96::/48'
volumeMounts:
- name: cni-cfg
mountPath: /etc/cni/net.d
- name: xtables-lock
mountPath: /run/xtables.lock
readOnly: false
- name: lib-modules
mountPath: /lib/modules
readOnly: true
resources:
requests:
cpu: "100m"
memory: "50Mi"
limits:
cpu: "100m"
memory: "50Mi"
securityContext:
privileged: false
capabilities:
add: ["NET_RAW", "NET_ADMIN"]
volumes:
- name: cni-bin
hostPath:
path: /opt/cni/bin
type: DirectoryOrCreate
- name: cni-cfg
hostPath:
path: /etc/cni/net.d
type: DirectoryOrCreate
- name: xtables-lock
hostPath:
path: /run/xtables.lock
type: FileOrCreate
- name: lib-modules
hostPath:
path: /lib/modules
kind: ConfigMap
metadata:
name: cni-k8s-upgrade-and-conformance-rjzpyt-crs-0
namespace: default
---
apiVersion: addons.cluster.x-k8s.io/v1beta1
kind: ClusterResourceSet
metadata:
name: k8s-upgrade-and-conformance-rjzpyt-crs-0
namespace: default
spec:
clusterSelector:
matchLabels:
cni: k8s-upgrade-and-conformance-rjzpyt-crs-0
resources:
- kind: ConfigMap
name: cni-k8s-upgrade-and-conformance-rjzpyt-crs-0
strategy: ApplyOnce
---
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: KubeadmConfig
metadata:
name: k8s-upgrade-and-conformance-rjzpyt-mp-0-config
namespace: default
spec:
joinConfiguration:
nodeRegistration: {}
---
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
labels:
cni: k8s-upgrade-and-conformance-rjzpyt-crs-0
name: k8s-upgrade-and-conformance-rjzpyt
namespace: default
spec:
clusterNetwork:
pods:
cidrBlocks:
- 192.168.0.0/16
serviceDomain: cluster.local
services:
cidrBlocks:
- 10.128.0.0/12
topology:
class: quick-start
controlPlane:
metadata:
annotations:
Cluster.topology.controlPlane.annotation: Cluster.topology.controlPlane.annotationValue
labels:
Cluster.topology.controlPlane.label: Cluster.topology.controlPlane.labelValue
Cluster.topology.controlPlane.label.node.cluster.x-k8s.io: Cluster.topology.controlPlane.nodeLabelValue
nodeDeletionTimeout: 30s
nodeVolumeDetachTimeout: 5m
replicas: 1
variables:
- name: etcdImageTag
value: ""
- name: coreDNSImageTag
value: ""
- name: preLoadImages
value: []
version: v1.28.0-rc.1.9+3fb5377b25ec51
workers:
machineDeployments:
- class: default-worker
failureDomain: fd4
metadata:
annotations:
Cluster.topology.machineDeployment.annotation: Cluster.topology.machineDeployment.annotationValue
labels:
Cluster.topology.machineDeployment.label: Cluster.topology.machineDeployment.labelValue
Cluster.topology.machineDeployment.label.node.cluster.x-k8s.io: Cluster.topology.machineDeployment.nodeLabelValue
minReadySeconds: 5
name: md-0
nodeDeletionTimeout: 30s
nodeVolumeDetachTimeout: 5m
replicas: 2
strategy:
rollingUpdate:
maxSurge: 20%
maxUnavailable: 0
type: RollingUpdate
---
apiVersion: cluster.x-k8s.io/v1beta1
kind: MachinePool
metadata:
name: k8s-upgrade-and-conformance-rjzpyt-mp-0
namespace: default
spec:
clusterName: k8s-upgrade-and-conformance-rjzpyt
failureDomains:
- fd4
- fd5
- fd6
- fd7
- fd8
replicas: 2
template:
spec:
bootstrap:
configRef:
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: KubeadmConfig
name: k8s-upgrade-and-conformance-rjzpyt-mp-0-config
clusterName: k8s-upgrade-and-conformance-rjzpyt
infrastructureRef:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachinePool
name: k8s-upgrade-and-conformance-rjzpyt-dmp-0
version: v1.28.0-rc.1.9+3fb5377b25ec51
---
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachinePool
metadata:
name: k8s-upgrade-and-conformance-rjzpyt-dmp-0
namespace: default
spec:
template:
preLoadImages: []What I am able to observe is: for the normal DockerMachines, we set In the mapper we then return a "BestGuess" in
This gets called from the dockermachinepool_controller here: Which in this case then will be |
|
Hm. This will be brought in sync soon with Willie's CC MP PR. What options do you see in the meantime? Also wondering why our periodic works |
Periodic works because the mapper does not have an entry for Or in other words: this PR introduces the mapper entry for Current options I see is:
|
|
Taking a step back: a different fix would be to adjust https://github.com/kubernetes-sigs/cluster-api/blob/5350e793ce279aaa048ba51d87e309bbb2ee89d4/scripts/ci-e2e-lib.sh : Change the handling of |
|
/test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-main |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
pull-cluster-api-e2e-workload-upgrade-1-28-latest-main |
|
/test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main |
|
/area testing |
k8s-ci-robot
added
area/testing
|
Note: we decided to merge First to get a working upgrade-1-28-latest job. The issue should be fixed for the next bump via #9016 |
|
job succeeded @sbueringer :-) |
|
Nice!! /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
14 tasks
6 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
According to #8708 : Modify quickstart and CAPD to use the new Kubernetes release:
Bump the Kubernetes version in:
test/*: search for occurrences of the previous Kubernetes versionTiltfileEnsure the latest available kind version is used (including the latest images for this kind release)
Verify the quickstart manually
Prior art:⚠️ Use Kubernetes 1.25 in Quick Start docs and CAPD. #7156
bump
InitWithKubernetesVersionandWorkloadKubernetesVersioninclusterctl_upgrade_test.goOpen TODOs:
finish kind image bump after release (also bump kind itself it was an entire release)verify we did everything defined in Update KIND to v0.21.0 and document upgrade process #8977Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates to #8708