🐛Certificate paths in cloud-init scripts should not use a platform-dependent path separator

[weiran-ms]

What this PR does / why we need it:
The path separator in cloud-init scripts should always be "/" and independent of the platform, so path.Join instead of filepath.Join should be used when generating the paths. If Kubeadm bootstrap provider runs in a Windows pod, the certificate paths in cloud-init scripts will be incorrect, and created clusters will not be started due to incorrect certificate paths.

/area bootstrap

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: weiran-ms / name: Wei Ran (470aaf0)

[k8s-ci-robot]

Welcome @weiran-ms!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @weiran-ms. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[sbueringer]

Makes sense to me
/lgtm

Would be good if someone who's more familiar with CAPI <=> Windows can take a look
/assign @CecileRobertMichon

(cc @jayunit100 @knabben)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 92d7dbbc851e72c76728d34a7245c14065689d39

[CecileRobertMichon]

/lgtm
/approve

This seems like a bug fix, should it be backported?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CecileRobertMichon]

cc @marosset @jsturtevant as well

[killianmuldoon]

This seems like a bug fix, should it be backported?

I think it should be.

/cherry-pick release-1.5

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

This seems like a bug fix, should it be backported?

I think it should be.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/cherry-pick release-1.4

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #9230

In response to this:

This seems like a bug fix, should it be backported?

I think it should be.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #9231

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[g-gaston]

/remove-area bootstrap
/area provider/bootstrap-kubeadm