Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Make dev cluster networking configurable #9183

Merged
merged 1 commit into from
Aug 14, 2023
Merged

🌱 Make dev cluster networking configurable #9183

merged 1 commit into from
Aug 14, 2023

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Aug 14, 2023 •
edited

What this PR does / why we need it:
Fixed KIND Config requiring docker networking with ipv6 support.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9000

@chaunceyjiang
Fixed KIND Config requiring docker networking with ipv6 support.
f137d0b 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @chaunceyjiang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaunceyjiang
Copy link
Contributor Author

/area devtools

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools and removed do-not-merge/needs-area PR is missing an area label labels Aug 14, 2023
@sbueringer
Copy link
Member

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8d2c495b9af30d18dfd52d7049a8591d5727e54

@sbueringer
Copy link
Member

sbueringer commented Aug 14, 2023 •
edited

Not sure if I would label this as a bugfix. Maybe "minor or other"?

killianmuldoon
killianmuldoon reviewed Aug 14, 2023
View reviewed changes
hack/kind-install-for-capd.sh
@@ -31,7 +31,8 @@ if [[ "${TRACE-0}" == "1" ]]; then
fi

KIND_CLUSTER_NAME=${CAPI_KIND_CLUSTER_NAME:-"capi-test"}

# See: https://kind.sigs.k8s.io/docs/user/configuration/#ip-family
KIND_NETWORK_IPFAMILY=${KIND_NETWORK_IPFAMILY:-"dual"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for adding this option!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@killianmuldoon
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@killianmuldoon
Copy link
Contributor

/retitle :seedling Make dev cluster networking configurable

@k8s-ci-robot k8s-ci-robot changed the title 🐛 Fixed KIND Config requiring docker networking with ipv6 support. :seedling Make dev cluster networking configurable Aug 14, 2023
@killianmuldoon killianmuldoon changed the title :seedling Make dev cluster networking configurable 🌱 Make dev cluster networking configurable Aug 14, 2023
@killianmuldoon
Copy link
Contributor

@sbueringer - WDYT of the new title?

@sbueringer
Copy link
Member

Sounds good / better

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e902db into kubernetes-sigs:main Aug 14, 2023
30 of 31 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 14, 2023
@chaunceyjiang chaunceyjiang deleted the dual branch August 15, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@vincepri vincepri Awaiting requested review from vincepri

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Config requiring docker network that supports ipv6 which is not a default setting
4 participants
@chaunceyjiang @k8s-ci-robot @sbueringer @killianmuldoon