Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump CAPI visualizer to v1.2.0 #9195

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Aug 15, 2023

What this PR does / why we need it: Bump CAPI visualizer to v1.2.0, which allows it to support MachinePool Machines in the tree view.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@Jont828 Jont828 changed the title :seed Bump CAPI visualizer to v1.2.0 馃尡 Bump CAPI visualizer to v1.2.0 Aug 15, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb270880a63ed5d8b8ba51d646cab221ffd07b55

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@killianmuldoon
Copy link
Contributor

/area devtools

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools and removed do-not-merge/needs-area PR is missing an area label labels Aug 23, 2023
@sbueringer
Copy link
Member

sbueringer commented Aug 23, 2023

Probably should regularly check for PRs with approve+lgtm+ no hold (or just for the needs-area label)

@killianmuldoon
Copy link
Contributor

Probably should regularly check for PRs with approve+lgtm+ no hold (or just for the needs-area label)

Pretty much good enough to take a look at PRs that have approved set IMO, but regular checking the PR backlog is definitely a good idea.

@k8s-ci-robot k8s-ci-robot merged commit 32169f3 into kubernetes-sigs:main Aug 23, 2023
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants