Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] 🌱 Update cert-manager to v1.12.3 #9198

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #9197

/assign sbueringer

@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label area/clusterctl Issues or PRs related to clusterctl size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 16, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ab16f6a094de1f43a8709aedb07dedeea01d7c4

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@sbueringer
Copy link
Member

Looks like we have to fix the broken link first:

ERROR: 1 dead links found!
[✖] https://github.com/Homebrew/homebrew-core/blob/master/Formula/clusterctl.rb → Status: 404

@mjlshen Do you have some time to take a look how we can fix this link and open a PR against main to fix it? (I think we also have the issue on main)

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Aug 16, 2023
@furkatgofurov7
Copy link
Member

Looks like we have to fix the broken link first:

ERROR: 1 dead links found!
[✖] https://github.com/Homebrew/homebrew-core/blob/master/Formula/clusterctl.rb → Status: 404

@mjlshen Do you have some time to take a look how we can fix this link and open a PR against main to fix it? (I think we also have the issue on main)

Looks like homebrew moved all formulas into its own subdirectories based on alphabetical order and now clusterctl lives in: https://github.com/Homebrew/homebrew-core/blob/master/Formula/c/clusterctl.rb

@furkatgofurov7
Copy link
Member

(I think we also have the issue on main)

I wonder why main md links job did not complain about it 🤔

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mjlshen
Copy link
Contributor

mjlshen commented Aug 17, 2023

It ended up getting fixed before I got to it #9208 - thanks!
/retest

@sbueringer
Copy link
Member

sbueringer commented Aug 17, 2023

@mjlshen looks like we need manual cherrypicks for the PR that fixes the link. Do you have some time to open those?

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mjlshen
Copy link
Contributor

mjlshen commented Aug 18, 2023

@mjlshen looks like we need manual cherrypicks for the PR that fixes the link. Do you have some time to open those?

@sbueringer done in #9238

If that looks good (first time doing something like this) I'm happy to also continue to manually cherry pick it down to release-1.4 to unblock the automated release-1.4 cherry-pick of this PR

@sbueringer
Copy link
Member

@mjlshen Minor detail on the PR title. Looks good thx

Signed-off-by: Michael Shen <mishen@umich.edu>
@sbueringer sbueringer force-pushed the cherry-pick-9197-to-release-1.5 branch from 346900f to 617fd83 Compare August 18, 2023 08:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@sbueringer
Copy link
Member

Rebased to pick up the fixed link

@sbueringer
Copy link
Member

/assign @killianmuldoon
for lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-release-1-5 617fd83 link false /test pull-cluster-api-apidiff-release-1-5

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51bea9354eb4ce1532c3e38203fc764e2cd55132

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [killianmuldoon,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1c8860d into kubernetes-sigs:release-1.5 Aug 18, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants