Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 🐛 Allow unsetting useExperimentalRetryJoin field from KubeadmControlPlane #9202

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[release-1.5] 🐛 Allow unsetting useExperimentalRetryJoin field from KubeadmControlPlane #9202

merged 1 commit into from
Aug 16, 2023

Conversation

MaxFedotov
Copy link
Contributor

What this PR does / why we need it:

This is a cherry-pick of changes merged in #9170 to release-1.5

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9169

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MaxFedotov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MaxFedotov / name: Max Fedotov (c1f3d78)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 16, 2023
@MaxFedotov MaxFedotov changed the base branch from main to release-1.5 August 16, 2023 08:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2023
@MaxFedotov
Copy link
Contributor Author

@sbueringer sorry for easy CLA errors and other stuff, I accidentally used main branch for merge and updated It after

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2023
@killianmuldoon
Copy link
Contributor

/check-cla

@sbueringer
Copy link
Member

@MaxFedotov No problem, not sure if there is a way for us to fix it without re-opening the PR

@sbueringer sbueringer closed this Aug 16, 2023
@sbueringer sbueringer removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 16, 2023
@sbueringer sbueringer reopened this Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 16, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99af7783bca7d5dfe21aace393ddd836ad19d48c

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 16, 2023
killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [killianmuldoon,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f985687 into kubernetes-sigs:release-1.5 Aug 16, 2023
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Unable to remove useExperimentalRetryJoin field from KubeadmControlPlaneTemplate
4 participants
@MaxFedotov @k8s-ci-robot @killianmuldoon @sbueringer