📖 Add task to update link checker base branch

[killianmuldoon]

Add a task to update the base branch in our PR markdown link checking action when creating a new release branch.

/area release

[killianmuldoon]

@kubernetes-sigs/cluster-api-release-team

Not sure if this should be added to the checklist of tasks.

[killianmuldoon]

We need to do something similar on CAPV - and change the base_branch listed in the older branches.

[sbueringer]

/lgtm
/approve

/hold

Change is fine for now. Would be good if this action could auto-discover the base branch. (or simply look at the delta in the PR). But this can be a follow-up. Feel free to unhold

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d42739f883da2f6c779a4dce4301e96f0fb6490c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• docs/OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/hold cancel

[killianmuldoon]

Doesn't look like the capability exists for this action: https://github.com/gaurav-nelson/github-action-markdown-link-check#check-only-modified-files-in-a-pull-request

We could disable the PR link checker entirely for older branches as it's not really that useful there, but that's as much work as updating the branch and requires a bit of explanation besides.

[sbueringer]

Alright. Thx for looking it up. Then let's go with manually updating the branch

[sbueringer]

Thank you very much for taking care of this!

Please follow-up with the same for CAPV.

[sbueringer]

/cherry-pick release-1.5

[sbueringer]

/cherry-pick release-1.4

[k8s-infra-cherrypick-robot]

@sbueringer: #9208 failed to apply on top of branch "release-1.5":

Applying: Add task to update link checker base branch
Using index info to reconstruct a base tree...
M	docs/release/release-tasks.md
Falling back to patching base and 3-way merge...
Auto-merging docs/release/release-tasks.md
CONFLICT (content): Merge conflict in docs/release/release-tasks.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add task to update link checker base branch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #9208 failed to apply on top of branch "release-1.4":

Applying: Add task to update link checker base branch
Using index info to reconstruct a base tree...
M	docs/release/release-tasks.md
Falling back to patching base and 3-way merge...
Auto-merging docs/release/release-tasks.md
CONFLICT (content): Merge conflict in docs/release/release-tasks.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add task to update link checker base branch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

No need to cherry-pick release docs back IMO - I don't think it's worth the effort to keep them in sync.

[sbueringer]

Agree, I tried it for the fix of the broken link.
I asked @mjlshen for manual cherrypicks now