Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set #9244

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Prior art: https://github.com/kubernetes-sigs/metrics-server/blob/9dbb59e99addce5956f65d6e44749fb36eef339e/.github/workflows/gh-workflow-approve.yaml

Tested at chrischdi/cluster-api-provider-vsphere#4

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9215

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@chrischdi chrischdi changed the title github: add workflow to auto-approve golangci-lint if ok-to-test label is set 🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set Aug 18, 2023
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just one nit

.github/workflows/pr-gh-workflow-approve.yaml Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/area ci

/lgtm

Let's give others some time to review and otherwise merge next week and just give it a try

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci and removed do-not-merge/needs-area PR is missing an area label labels Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0cf2959b6f855a97ddc0fc848f9ef78303d7233f

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit b820a31 into kubernetes-sigs:main Aug 21, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 21, 2023
@chrischdi chrischdi deleted the pr-ok-to-test-workflow branch August 21, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run golangci-lint as soon as ok-to-test is set
4 participants