Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 github: add edited and reopened as triggers for the GH workflow approval #9259

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds the types edited and reopened to the triggers for the PR approve GH Workflows action.

Before this PR the golangci-lint action could have been triggered by the edited or reopened actions.
The approval workflow would not get triggered in that case and did not approve the linter.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9215

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@chrischdi
Copy link
Member Author

/assign @sbueringer
/assign @killianmuldoon

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for getting this fix in.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5728747dc1aa24a20cbe6b29c40fd7826d2eb0e1

@sbueringer
Copy link
Member

/approve

let's give this a try

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8778642 into kubernetes-sigs:main Aug 21, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 21, 2023
@killianmuldoon
Copy link
Contributor

I updated the description of this PR: #9251 manually and that correctly approved the workflow run and started the linter.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run golangci-lint as soon as ok-to-test is set
4 participants