Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Promote chrischdi to cluster-api reviewer #9286

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:
This PR adds @chrischdi (myself) to cluster-api-reviewers 馃檪 馃檭 .

I was added as reviewer back in January (#7996) for topology controller, CAPD and test*.
Since then I also took part in the release team for v1.5 as shadow for the CI Signal/Bug triage/Automation Manager sub-team where I especially worked on deflaking some of our e2e tests during that cycle.
Besides that I contributed code for custom resource metrics for CAPI which got used e.g. for getting better insights for the scale testing (#8814) efforts.

By getting promoted to a reviewer of all parts in CAPI, I'd like to help the community to spread the work across more people.

To get a list of all my contributions to CAPI:

/cc @fabriziopandini @killianmuldoon @sbueringer

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2023
@chrischdi
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挴

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6330890730d4b4c93d45441fb865489918ee1a87

@killianmuldoon
Copy link
Contributor

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Aug 23, 2023
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big +1 from me
Thank you for all you have done so far and looking forward for more of your contributions!

@fabriziopandini
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

馃挴

/lgtm

Thank you very much for all you work on core CAPI!!!

@elmiko
Copy link
Contributor

elmiko commented Aug 23, 2023

+1 , thanks for the hard work Christian!

@richardcase
Copy link
Member

A big 馃憤 from me

/lgtm

@elmiko
Copy link
Contributor

elmiko commented Aug 23, 2023

we are leaving this open for 1 week from today for lazy consensus.

@CecileRobertMichon
Copy link
Contributor

/lgtm

+1 from my side as well, thank you @chrischdi for all your contributions so far!

@furkatgofurov7
Copy link
Member

Thanks, @chrischdi for all your contributions!

+1

@sbueringer
Copy link
Member

sbueringer commented Aug 29, 2023

/approve

(Lazy consensus is until tomorrow)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@sbueringer
Copy link
Member

sbueringer commented Aug 30, 2023

Lazy consensus deadline expired. Congrats @chrischdi!

And thx for volunteering to take over more responsibilities which basically means more work 馃槃

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit f79e725 into kubernetes-sigs:main Aug 30, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 30, 2023
@chrischdi
Copy link
Member Author

Lazy consensus deadline expired. Congrats @chrischdi!

And thx for volunteering to take over more responsibilities which basically means more work 馃槃

/hold cancel

Thanks to everyone for the support! 馃槃 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants