Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 add step for indexing the CRDs of the latest release #9291

Merged

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Aug 23, 2023

What this PR does / why we need it:
Adds a step in the release cycle for ensuring the most recent release version is indexed for cluster API repo in docs.crds.dev

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #9290

/area release
/kind documentation

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2023
@cahillsf
Copy link
Member Author

/cc @furkatgofurov7

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ea96c57c95443e8d29a1c6de942dd5bd47c66fa

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

/lgtm

@furkatgofurov7
Copy link
Member

@cahillsf can you link the issue this PR fixes in the description, unless you want to keep it open?

@sbueringer
Copy link
Member

@cahillsf can you link the issue this PR fixes in the description, unless you want to keep it open?

We should always link it, either via "fixes" or "part of" (the latter if we don't want to close the issue)

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 810a86f into kubernetes-sigs:main Aug 24, 2023
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 24, 2023
@cahillsf cahillsf deleted the cahillsf/add-update-crds-step branch August 24, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants