Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 🌱 Add test for ownerReference apiVersion update #9297

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[release-1.5] 🌱 Add test for ownerReference apiVersion update #9297

merged 1 commit into from
Aug 24, 2023

Conversation

killianmuldoon
Copy link
Contributor

Manual cherry-pick of #9269

Add an end-to-end test to ensure that the apiVersions of ownerReferences are updated to the current version of the CAPI APIs. This change allows testing apiVersion bumps when CAPI has no existing apiVersion available to create a cluster with.

@killianmuldoon
Add synthetic test for ownerReference apiVersion update
f60dc3c 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2023
@killianmuldoon
Copy link
Contributor Author

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Aug 24, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-5
  • /test pull-cluster-api-e2e-release-1-5
  • /test pull-cluster-api-test-release-1-5
  • /test pull-cluster-api-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-5
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-release-1-5
  • /test pull-cluster-api-e2e-full-release-1-5
  • /test pull-cluster-api-e2e-informing-release-1-5
  • /test pull-cluster-api-e2e-mink8s-release-1-5
  • /test pull-cluster-api-e2e-scale-release-1-5-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-release-1-5
  • /test pull-cluster-api-test-mink8s-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-5
  • pull-cluster-api-build-release-1-5
  • pull-cluster-api-e2e-informing-release-1-5
  • pull-cluster-api-e2e-release-1-5
  • pull-cluster-api-test-release-1-5
  • pull-cluster-api-verify-release-1-5

In response to this:

/test pull-cluster-api-e2e-full-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon killianmuldoon changed the title 🌱 Add synthetic test for ownerReference apiVersion update [release-1.5] 🌱 Add test for ownerReference apiVersion update Aug 24, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

chrischdi
chrischdi reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6946ebd8367b8fa33b72741e0e551effa8252599

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-5
  • /test pull-cluster-api-e2e-release-1-5
  • /test pull-cluster-api-test-release-1-5
  • /test pull-cluster-api-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-5
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-release-1-5
  • /test pull-cluster-api-e2e-full-release-1-5
  • /test pull-cluster-api-e2e-informing-release-1-5
  • /test pull-cluster-api-e2e-mink8s-release-1-5
  • /test pull-cluster-api-e2e-scale-release-1-5-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-release-1-5
  • /test pull-cluster-api-test-mink8s-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-5
  • pull-cluster-api-build-release-1-5
  • pull-cluster-api-e2e-informing-release-1-5
  • pull-cluster-api-e2e-release-1-5
  • pull-cluster-api-test-release-1-5
  • pull-cluster-api-verify-release-1-5

In response to this:

/test pull-cluster-api-e2e-full-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-5

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 551ea99 into kubernetes-sigs:release-1.5 Aug 24, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@killianmuldoon @k8s-ci-robot @sbueringer @chrischdi