Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Allow duplicate objects in Tiltfile #9302

Merged
merged 1 commit into from
Aug 25, 2023
Merged

🐛 Allow duplicate objects in Tiltfile #9302

merged 1 commit into from
Aug 25, 2023

Conversation

prometherion
Copy link
Contributor

What this PR does / why we need it:

Support for duplicated resources when debugging with Tilt.

Providers could require add-ons which have duplicated Namespace objects, thus breaking the Tilt setup.

Which issue(s) this PR fixes:
Fixes #9300

@jds9090 @prometherion
feat(tilt): allowing duplicates
7f2fb90 
Co-authored-by: Dario Tranchitella <dario@tranchitella.eu>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 24, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jds9090 / name: daseul cho (7f2fb90)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @prometherion. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Aug 24, 2023 •
edited

Please check the CLA error + the PR title

killianmuldoon
killianmuldoon reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/area devtools
/retitle 🐛 Allow duplicate objects in Tiltfile

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot changed the title feat(tilt): allowing duplicates 🐛 Allow duplicate objects in Tiltfile Aug 24, 2023
@k8s-ci-robot k8s-ci-robot removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-area PR is missing an area label labels Aug 24, 2023
@killianmuldoon
Copy link
Contributor

/check-cla

@prometherion have you signed the CLA? Not sure if it's bugging out.

killianmuldoon
killianmuldoon reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b745cbfda1a333feef332117678d75f05823f294

@sbueringer
Copy link
Member

/check-cla

@prometherion have you signed the CLA? Not sure if it's bugging out.

Looks like the PR is currently co-authored. See #9302 (comment)

furkatgofurov7
furkatgofurov7 reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 25, 2023
@jds9090
Copy link
Contributor

jds9090 commented Aug 25, 2023

/check-cla
@prometherion have you signed the CLA? Not sure if it's bugging out.

Looks like the PR is currently co-authored. See #9302 (comment)

Sorry for the delay. I have signed it.

@sbueringer
Copy link
Member

No worries

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e3ef78 into kubernetes-sigs:main Aug 25, 2023
28 of 29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Tilt: allowing duplicated resources for addons/providers
6 participants
@prometherion @k8s-ci-robot @sbueringer @killianmuldoon @jds9090 @furkatgofurov7