Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 document verification steps for capi images #9305

Merged
merged 1 commit into from
Sep 6, 2023
Merged

馃摉 document verification steps for capi images #9305

merged 1 commit into from
Sep 6, 2023

Conversation

kranurag7
Copy link
Contributor

@kranurag7 kranurag7 commented Aug 24, 2023 •
edited

What this PR does / why we need it:

  • This PR documents verification steps for CAPI container images.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9292

Image Ref: https://explore.ggcr.dev/?repo=registry.k8s.io/cluster-api

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kranurag7!

It looks like this is your first PR to kubernetes-sigs/cluster-api 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kranurag7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon
killianmuldoon reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, few nits from my side:

docs/book/src/tasks/verify-container-images.md Outdated Show resolved Hide resolved
docs/book/src/tasks/verify-container-images.md Show resolved Hide resolved
@furkatgofurov7
Copy link
Member

@kubernetes-sigs/cluster-api-release-team

@furkatgofurov7
Copy link
Member

LGTM pending squash from my side 馃檪

@kranurag7
Document verification steps for capi images
373b298 
Document verification of CAPI images with cosign.

Signed-off-by: Anurag <contact.anurag7@gmail.com>
@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
furkatgofurov7
furkatgofurov7 reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbueringer
Copy link
Member

Someone will have to do a regular lgtm :D

willie-yao
willie-yao approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 546f1a2f471ca7b4e66eda04bb27f5c1056c15db

@k8s-ci-robot k8s-ci-robot merged commit ec92242 into kubernetes-sigs:main Sep 6, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 6, 2023
@kranurag7 kranurag7 deleted the verify-images branch May 7, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannesfrey johannesfrey johannesfrey left review comments

@sbueringer sbueringer sbueringer left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@willie-yao willie-yao willie-yao approved these changes

@richardcase richardcase Awaiting requested review from richardcase

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Document verification of CAPI artifacts
7 participants
@kranurag7 @k8s-ci-robot @furkatgofurov7 @sbueringer @johannesfrey @killianmuldoon @willie-yao