Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 馃尡 Bump corefile-migration library to v1.0.21 #9309

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[release-1.5] 馃尡 Bump corefile-migration library to v1.0.21 #9309

merged 1 commit into from
Aug 25, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 25, 2023 •
edited

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:
Manual cherry-pick of #9307

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Bump corefil-migration library to v1.0.21
8559024 
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2023
@sbueringer
Copy link
Member Author

/assign @killianmuldoon @furkatgofurov7 @chrischdi

@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 25, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area dependency

docs/book/src/reference/versions.md
@@ -144,6 +144,9 @@ The Kubeadm Control Plane requires the Kubeadm Bootstrap Provider.
| v1.3 (v1beta1) | v1.10.0 |
| >= v1.3.4 (v1beta1) | v1.10.1 |
| v1.4 (v1beta1) | v1.10.1 |
| >= v1.4.6 (v1beta1) | v1.11.1 |
| v1.5 (v1beta1) | v1.10.1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked it in other PR, is this correct v1.5 <=> v1.10.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is correct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oure CoreDNS support in this table depends on the migration library we use

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/coredns/corefile-migration v1.0.20

=> https://github.com/coredns/corefile-migration/releases/tag/v1.0.20

=> Corefile Migration v1.0.20 supports Corefile migrations through CoreDNS v1.10.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, will know next time :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome. No problem :) Thx for asking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just assuming PR authors know what they're doing wouldn't help much on PRs 馃槀

furkatgofurov7
furkatgofurov7 reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/book/src/reference/versions.md
@@ -144,6 +144,9 @@ The Kubeadm Control Plane requires the Kubeadm Bootstrap Provider.
| v1.3 (v1beta1) | v1.10.0 |
| >= v1.3.4 (v1beta1) | v1.10.1 |
| v1.4 (v1beta1) | v1.10.1 |
| >= v1.4.6 (v1beta1) | v1.11.1 |
| v1.5 (v1beta1) | v1.10.1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, will know next time :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 859662a92f20a96aba638a7d1fa50c31a8bec146

killianmuldoon
killianmuldoon reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 97e10b0 into kubernetes-sigs:release-1.5 Aug 25, 2023
24 of 25 checks passed
@sbueringer sbueringer deleted the pr-bump-core-mi-1.5 branch August 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@richardcase richardcase Awaiting requested review from richardcase

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbueringer @k8s-ci-robot @furkatgofurov7 @killianmuldoon @chrischdi