🌱 Refactor e2e ownerRef test utils #9313
Conversation
k8s-ci-robot
added
area/e2e-testing
k8s-ci-robot
added
the
size/M
| @@ -168,7 +169,7 @@ var CoreOwnerReferenceAssertion = map[string]func([]metav1.OwnerReference) error | |||
| }, | |||
| machineKind: func(owners []metav1.OwnerReference) error { | |||
| // Machines must be owned and controlled by a MachineSet or a KubeadmControlPlane, depending on if this Machine is part of a ControlPlane or not. | |||
| return HasOneOfExactOwners(owners, []simpleOwnerRef{machineSetController}, []simpleOwnerRef{kubeadmControlPlaneController}) | |||
There was a problem hiding this comment.
This param which is unexported was the main problem, but I think the refactor to just using ordinary ownerRefs with a custom string method makes this simpler.
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-refactor-ownerRef-utils
branch
from
8406661
to
cecb01d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d279e00fb5d6855d4cbc06527a2f265b95ef61e1
|
|
/cherry-pick release-1.5 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #9314 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update some utils in the ownerRef e2e test package to make these functions easier to import.
/area e2e-testing