Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Minor fixes for CC+MP implementation #9318

Merged
merged 1 commit into from
Aug 29, 2023
Merged

馃尡 Minor fixes for CC+MP implementation #9318

merged 1 commit into from
Aug 29, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 25, 2023 •
edited

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:
Follow-up to #9016

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5991

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2023
@sbueringer sbueringer changed the title Minor fixes for CC+MP implementation 馃尡 Minor fixes for CC+MP implementation Aug 25, 2023
@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 25, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

chrischdi
chrischdi reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, contains some important fixes!

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44a196f447a4a46a657c26b5466143810d4afb0c

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2023
@sbueringer
Copy link
Member Author

Should be ready for review now (@chrischdi sorry I did another iteration)

/assign @killianmuldoon @chrischdi

@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot

This comment was marked as resolved.

Sign in to view
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main

@sbueringer
Copy link
Member Author

sbueringer commented Aug 28, 2023 •
edited

/assign @willie-yao
PTAL as well (and no worries, I just found a bit more when reviewing another 2-3 times :D)

willie-yao
willie-yao reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit from my end. Thanks for all the fixes! I definitely missed a lot of things 馃槄

internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

Just one minor nit from my end. Thanks for all the fixes! I definitely missed a lot of things 馃槄

No worries. I'm working since 1-2 years on ClusterClass and also missed them in the first few rounds of reviews

@chrischdi
Copy link
Member

Only willie's nit, as of that lgtm :-)

@sbueringer
Minor fixes for CC+MP implementation
8965f4c 
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35b18819d4b32db3c3ba8881d8712fd711255988

killianmuldoon
killianmuldoon reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
/lgtm
/approve

/hold
For the full CI run.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8cb4d00 into kubernetes-sigs:main Aug 29, 2023
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 29, 2023
@sbueringer sbueringer deleted the pr-cc-mp-squashed-nits branch August 29, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@willie-yao willie-yao willie-yao left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@killianmuldoon killianmuldoon

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbueringer @k8s-ci-robot @chrischdi @killianmuldoon @willie-yao