Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Improve release notes formatting #9337

Merged

Conversation

g-gaston
Copy link
Contributor

What this PR does / why we need it:

  • Capitalize titles even after trimming and removing duplicated area prefixes.
  • Sort docs PR entries to make the output consistent across runs.

/area release

* Capitalize titles even after trimming and removing duplicated area
  prefixes.
* Sort docs PR entries to make the output consistent across runs.
@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2023
@nawazkh
Copy link
Member

nawazkh commented Aug 30, 2023

/lgtm
馃殌

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: baf63b050f3421dd3b59131ac386c81e52672fae

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@g-gaston
Copy link
Contributor Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot k8s-ci-robot merged commit 3ea7155 into kubernetes-sigs:main Aug 30, 2023
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants