Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 golangci-lint: replace deprecated local-prefixes setting for gci #9339

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Aug 30, 2023

What this PR does / why we need it:

The local-prefixes setting is deprecated. (see the docs).

This replaces it by the custom-order and sections setting.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2023
@chrischdi chrischdi changed the title golangci-lint: replace deprecated local-prefixes setting for gci 馃尡 golangci-lint: replace deprecated local-prefixes setting for gci Aug 30, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f23b8f0e171e041986820893c07d9f2723d5d7d

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@sbueringer
Copy link
Member

nice catch @MrDXY via kubernetes-sigs/cluster-api-provider-vsphere#2294

@k8s-ci-robot k8s-ci-robot merged commit a138746 into kubernetes-sigs:main Aug 30, 2023
28 of 30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 30, 2023
@chrischdi chrischdi deleted the pr-golangcilint-fix-gci-config branch August 30, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants