Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 hack: bump kube-state-metrics and prometheus charts #9352

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Sep 1, 2023

What this PR does / why we need it:

This bumps the prometheus and kube-state-metrics helm charts.

Especially this includes fixes for kube-state-metrics by bumping it to v2.10.0:

Make sure to run make clean-charts!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #8951

/area metrics

@k8s-ci-robot k8s-ci-robot added area/metrics Issues or PRs related to metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2023
@chrischdi chrischdi changed the title hack: bump kube-state-metrics and prometheus charts 馃尡 hack: bump kube-state-metrics and prometheus charts Sep 1, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid question - where are these version numbers from? The kube-state-metrics one at least doesn't track the upstream release numbers.

@sbueringer
Copy link
Member

sbueringer commented Sep 1, 2023

Thank you very much for your work on kube-state-metrics!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@chrischdi
Copy link
Member Author

These are Chart versions:

The actual version of kube-state-metrics or prometheus is in there as appVersion

@killianmuldoon
Copy link
Contributor

Thanks for the answers!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31b2183e8c1078fdc8ea1add607d94d4cababc68

@k8s-ci-robot k8s-ci-robot merged commit b259764 into kubernetes-sigs:main Sep 1, 2023
33 of 34 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/metrics Issues or PRs related to metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants