🌱 Add unit tests for reconcile_state, cluster_controller, & conditions #9380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/area testing |
k8s-ci-robot
added
area/testing
willie-yao
force-pushed
the
cc-mp-unit-tests-2
branch
from
c4154d1
to
e49f1ea
Compare
k8s-ci-robot
added
size/XL
willie-yao
force-pushed
the
cc-mp-unit-tests-2
branch
13 times, most recently
from
34bced2
to
60d9728
Compare
|
/retest |
willie-yao
force-pushed
the
cc-mp-unit-tests-2
branch
2 times, most recently
from
b0cebed
to
a95dcd0
Compare
k8s-ci-robot
added
size/XXL
willie-yao
changed the title
willie-yao
force-pushed
the
cc-mp-unit-tests-2
branch
2 times, most recently
from
dfdb378
to
1995bf2
Compare
chrischdi
reviewed
Sep 14, 2023
internal/controllers/topology/cluster/cluster_controller_test.go
Outdated
Show resolved
Hide resolved
willie-yao
force-pushed
the
cc-mp-unit-tests-2
branch
2 times, most recently
from
cdf0877
to
12cd28d
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 61f6cf78bcc0bbae17a61e4192cd7c59215e34d6
|
39 tasks
k8s-ci-robot
removed
the
lgtm
sbueringer
force-pushed
the
cc-mp-unit-tests-2
branch
from
96fa559
to
8560925
Compare
|
/lgtm for squashing-verification 😂 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d18e2a5b7bf32e8a7a2fd53235a0a97f2de97c1c
|
|
/lgtm pending squash |
sbueringer
force-pushed
the
cc-mp-unit-tests-2
branch
from
8560925
to
53b84a3
Compare
|
@willie-yao Thank you very much!! Really appreciate it, a lot of annoying work :) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
force-pushed
the
cc-mp-unit-tests-2
branch
from
53b84a3
to
1ae8a33
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 85bf39df5c08e1893a73c82f774e67fc0fe71151
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds tests for the new ClusterClass MachinePool implementation for the following files:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #5991
/area testing