Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 Improve comment on MachineDeploymentStrategyType #9386

Merged
merged 1 commit into from
Sep 8, 2023
Merged

馃摉 Improve comment on MachineDeploymentStrategyType #9386

merged 1 commit into from
Sep 8, 2023

Conversation

rvanderp3
Copy link
Contributor

What this PR does / why we need it:
This PR improves the description for the field deployment.spec.strategy.type.

Which issue(s) this PR fixes:
Fixes #9376

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rvanderp3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/area api

@k8s-ci-robot k8s-ci-robot added area/api Issues or PRs related to the APIs and removed do-not-merge/needs-area PR is missing an area label labels Sep 7, 2023
killianmuldoon
killianmuldoon reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 501c6a75d8db94fa894f53d82838bceba304a8fe

killianmuldoon
killianmuldoon reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/retitle 馃摉 Improve comment on MachineDeploymentStrategyType
/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot changed the title 馃悰 expand machine phase hooks enhancement 馃摉 Improve comment on MachineDeploymentStrategyType Sep 7, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2023
@sbueringer
Copy link
Member

Thx. Look like you also have to re-gen the openapi stuff (or just modify it manually according to the diff in the verify job, that's probably quicker)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@rvanderp3
Copy link
Contributor Author

Thx. Look like you also have to re-gen the openapi stuff (or just modify it manually according to the diff in the verify job, that's probably quicker)

thanks @sbueringer! that update has been made and this is ready for review.

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5aff723ef0f106ea44f7b5c4723270442a4cf9e9

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 826494a into kubernetes-sigs:main Sep 8, 2023
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 8, 2023
@rvanderp3 rvanderp3 mentioned this pull request Nov 2, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@ykakarap ykakarap Awaiting requested review from ykakarap

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Improve description for machine deployment.spec.strategy.type
4 participants
@rvanderp3 @k8s-ci-robot @sbueringer @killianmuldoon