Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 extend test/framework to collect workload cluster nodes #9416

Merged
merged 1 commit into from
Sep 15, 2023
Merged

🌱 extend test/framework to collect workload cluster nodes #9416

merged 1 commit into from
Sep 15, 2023

Conversation

rvanderp3
Copy link
Contributor

What this PR does / why we need it:
Collects node yaml from workload cluster to assist in e2e failure analysis.

Which issue(s) this PR fixes:
Fixes #9250

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rvanderp3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023
@rvanderp3
Copy link
Contributor Author

/label area/testing

@k8s-ci-robot
Copy link
Contributor

@rvanderp3: The label(s) /label area/testing cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label area/testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/area testing

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing and removed do-not-merge/needs-area PR is missing an area label labels Sep 13, 2023
chrischdi
chrischdi reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all lgtm.

We should add a note at https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md to signal this change.

Prior art: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.3-to-v1.4.md?plain=1#L76

@rvanderp3 rvanderp3 force-pushed the ISSUE-9250 branch 2 times, most recently from 907d8ad to 029162e Compare September 13, 2023 14:17
@rvanderp3
Copy link
Contributor Author

All in all lgtm.

We should add a note at https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md to signal this change.

Prior art: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.3-to-v1.4.md?plain=1#L76

Thanks for reviewing! I added a note.

killianmuldoon
killianmuldoon reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Will be good to get a dump in the test output to see what this looks like in practice.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@rvanderp3 rvanderp3 force-pushed the ISSUE-9250 branch 2 times, most recently from 8d91fd7 to 70d947f Compare September 14, 2023 19:04
killianmuldoon
killianmuldoon reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thankyou!

@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 88304d6f30e27eec289ec1f2ff7a7e9d5b010f65

chrischdi
chrischdi reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit

/lgtm

@chrischdi
Copy link
Member

Awesome work!

sbueringer
sbueringer reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Just two nits + #9416 (comment)

test/framework/alltypes_helpers.go Outdated Show resolved Hide resolved
test/framework/alltypes_helpers.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
chrischdi
chrischdi reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7eb703f645fcf85e1e3fca939444481a813cb80

@sbueringer
Copy link
Member

Thank you very much! This will be very useful to debug e2e test issues ;)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1735aa5 into kubernetes-sigs:main Sep 15, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 15, 2023
sbueringer
sbueringer reviewed Sep 19, 2023
View reviewed changes
test/framework/alltypes_helpers.go
@@ -178,7 +184,7 @@ func dumpObject(resource runtime.Object, logPath string) {
namespace := metaObj.GetNamespace()
name := metaObj.GetName()

resourceFilePath := filepath.Clean(path.Join(logPath, namespace, kind, name+".yaml"))
resourceFilePath := filepath.Clean(path.Join(logPath, kind, namespace, name+".yaml"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to parse the artifacts folder and this change makes it very had:

After this change:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9393/pull-cluster-api-e2e-full-main/1702754124908466176/artifacts/clusters/bootstrap/resources/

Before this change:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-release-1-5/1704077878771060736/artifacts/clusters/bootstrap/resources/

Before it was easy to go into a folder for a namespace / test case and go through various resources. Now it's pretty hard because it's always necessary to go up and down two levels. I prefer by far the grouping by namespace and then kind over first kind and then namespace

Can we revert this change?

@killianmuldoon @chrischdi Opinions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to revert - I think you're right that namespace first is maps better onto how we've actually used this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #9462 (for reference)

@sbueringer sbueringer mentioned this pull request Sep 19, 2023
Merged
@rvanderp3 rvanderp3 mentioned this pull request Nov 2, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Extend test/framework to collect workload cluster nodes
5 participants
@rvanderp3 @k8s-ci-robot @killianmuldoon @chrischdi @sbueringer